From 3b6424fa29bbf2f9d1cee65f1bed4be033cbbc8e Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 23 May 2019 11:22:44 +0200 Subject: [PATCH] deps: histogram: unexport symbols Fixes: https://github.com/nodejs/node-gyp/issues/1755 Fixes: https://github.com/nodejs/node/issues/27778 PR-URL: https://github.com/nodejs/node/pull/27779 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Joyee Cheung Reviewed-By: Richard Lau --- deps/histogram/histogram.gyp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/deps/histogram/histogram.gyp b/deps/histogram/histogram.gyp index bcfa198f9d37c1..e3f5fd7a46bb72 100644 --- a/deps/histogram/histogram.gyp +++ b/deps/histogram/histogram.gyp @@ -3,6 +3,10 @@ { 'target_name': 'histogram', 'type': 'static_library', + 'cflags': ['-fvisibility=hidden'], + 'xcode_settings': { + 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden + }, 'include_dirs': ['src'], 'direct_dependent_settings': { 'include_dirs': [ 'src' ]