From 3c46ef471766bb02467393a75560af6c30b60b92 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 2 Aug 2017 16:57:43 -0700 Subject: [PATCH] test: explain sloppy mode for test-global Add a comment explaining why test-global runs in sloppy mode rather than strict mode. While in the file, make some minor changes to the module ordering and spacing to conform with our test writing guide. Also reordered arguments in `assert.strictEqual()` to match documentation. PR-URL: https://github.com/nodejs/node/pull/14604 Reviewed-By: Refael Ackermann Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum Reviewed-By: Sakthipriyan Vairamani Reviewed-By: James M Snell Reviewed-By: Gibson Fahnestock --- test/parallel/test-global.js | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/test/parallel/test-global.js b/test/parallel/test-global.js index 42e8eeb7274b21..2463a3d4ac0c48 100644 --- a/test/parallel/test-global.js +++ b/test/parallel/test-global.js @@ -19,28 +19,32 @@ // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // USE OR OTHER DEALINGS IN THE SOFTWARE. +// This test cannot run in strict mode because it tests that `baseFoo` is +// treated as a global without being declared with `var`/`let`/`const`. + /* eslint-disable strict */ const common = require('../common'); -const path = require('path'); + const assert = require('assert'); +const path = require('path'); common.globalCheck = false; baseFoo = 'foo'; // eslint-disable-line no-undef global.baseBar = 'bar'; -assert.strictEqual('foo', global.baseFoo, +assert.strictEqual(global.baseFoo, 'foo', 'x -> global.x in base level not working'); -assert.strictEqual('bar', - baseBar, // eslint-disable-line no-undef +assert.strictEqual(baseBar, // eslint-disable-line no-undef + 'bar', 'global.x -> x in base level not working'); const mod = require(path.join(common.fixturesDir, 'global', 'plain')); const fooBar = mod.fooBar; -assert.strictEqual('foo', fooBar.foo, 'x -> global.x in sub level not working'); +assert.strictEqual(fooBar.foo, 'foo', 'x -> global.x in sub level not working'); -assert.strictEqual('bar', fooBar.bar, 'global.x -> x in sub level not working'); +assert.strictEqual(fooBar.bar, 'bar', 'global.x -> x in sub level not working'); assert.strictEqual(Object.prototype.toString.call(global), '[object global]');