From 3ddf77fc249e458c0242550c862f372539defcb4 Mon Sep 17 00:00:00 2001 From: Pavol Otcenas Date: Sat, 17 Sep 2016 12:50:33 +0200 Subject: [PATCH] test: modernize js and tighten equality checking MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changed var --> const and let. Changed assert.notEqual --> assert.notStrictEqual Fixed comment spelling PR-URL: https://github.com/nodejs/node/pull/8618 Reviewed-By: James M Snell Reviewed-By: Myles Borins Reviewed-By: Michaƫl Zasso Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig --- test/parallel/test-child-process-cwd.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/test/parallel/test-child-process-cwd.js b/test/parallel/test-child-process-cwd.js index acba57939f0afe..8d0a28135ebf70 100644 --- a/test/parallel/test-child-process-cwd.js +++ b/test/parallel/test-child-process-cwd.js @@ -1,19 +1,19 @@ 'use strict'; -var common = require('../common'); -var assert = require('assert'); +const common = require('../common'); +const assert = require('assert'); -var returns = 0; +let returns = 0; /* Spawns 'pwd' with given options, then test - whether the exit code equals forCode, - optionally whether the stdout result matches forData - (after removing traling whitespace) + (after removing trailing whitespace) */ function testCwd(options, forCode, forData) { - var data = ''; + let data = ''; - var child = common.spawnPwd(options); + const child = common.spawnPwd(options); child.stdout.setEncoding('utf8'); @@ -46,7 +46,7 @@ if (common.isWindows) { // Assume does-not-exist doesn't exist, expect exitCode=-1 and errno=ENOENT { testCwd({cwd: 'does-not-exist'}, -1).on('error', common.mustCall(function(e) { - assert.equal(e.code, 'ENOENT'); + assert.strictEqual(e.code, 'ENOENT'); })); } @@ -58,7 +58,7 @@ testCwd({cwd: undefined}, 0); testCwd({cwd: null}, 0); // Check whether all tests actually returned -assert.notEqual(0, returns); +assert.notStrictEqual(returns, 0); process.on('exit', function() { - assert.equal(0, returns); + assert.strictEqual(returns, 0); });