From 3f41fcbe83d1cc600f305977c9a058143b1d83f7 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 24 Mar 2019 18:53:41 -0700 Subject: [PATCH] Revert "net: remove usage of require('util')" This reverts commit e112fb4c221f9749fd9271c95a5f544476511292. This commit broke parallel/test-net-access-byteswritten. PR-URL: https://github.com/nodejs/node/pull/26896 Reviewed-By: Ben Noordhuis Reviewed-By: Yongsheng Zhang Reviewed-By: Gus Caplan Reviewed-By: Colin Ihrig Reviewed-By: Refael Ackermann --- lib/net.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/net.js b/lib/net.js index 1c14df01ccb1e9..a5f012ac3302bb 100644 --- a/lib/net.js +++ b/lib/net.js @@ -23,8 +23,7 @@ const EventEmitter = require('events'); const stream = require('stream'); -const { inspect } = require('internal/util/inspect'); -const { debuglog } = require('internal/util/debuglog'); +const util = require('util'); const internalUtil = require('internal/util'); const { isIP, @@ -131,7 +130,7 @@ function getNewAsyncId(handle) { } -const debug = debuglog('net'); +const debug = util.debuglog('net'); function isPipeName(s) { return typeof s === 'string' && toNumber(s) === false; @@ -336,8 +335,7 @@ function Socket(options) { this[kBytesRead] = 0; this[kBytesWritten] = 0; } -Object.setPrototypeOf(Socket.prototype, stream.Duplex.prototype); -Object.setPrototypeOf(Socket, stream.Duplex); +util.inherits(Socket, stream.Duplex); // Refresh existing timeouts. Socket.prototype._unrefTimer = function _unrefTimer() { @@ -1414,7 +1412,7 @@ Server.prototype.listen = function(...args) { 'must have the property "port" or "path"'); } - throw new ERR_INVALID_OPT_VALUE('options', inspect(options)); + throw new ERR_INVALID_OPT_VALUE('options', util.inspect(options)); }; function lookupAndListen(self, port, address, backlog, exclusive, flags) {