From 4118e90b430bfec46069d74cc32d7f4481ca689e Mon Sep 17 00:00:00 2001 From: Victor Poriazov Date: Fri, 12 Oct 2018 13:55:28 -0400 Subject: [PATCH] test: fix order of assert arguments in vm-new-script-this-context Fixes the order of assert.strictEqual arguments. PR-URL: https://github.com/nodejs/node/pull/23558 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: Gireesh Punathil Reviewed-By: Trivikram Kamat --- test/parallel/test-vm-new-script-this-context.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/parallel/test-vm-new-script-this-context.js b/test/parallel/test-vm-new-script-this-context.js index 2c0c21690e1821..18f39f9086ae2a 100644 --- a/test/parallel/test-vm-new-script-this-context.js +++ b/test/parallel/test-vm-new-script-this-context.js @@ -27,7 +27,7 @@ const Script = require('vm').Script; // Run a string let script = new Script('\'passed\';'); const result = script.runInThisContext(script); -assert.strictEqual('passed', result); +assert.strictEqual(result, 'passed'); // Thrown error script = new Script('throw new Error(\'test\');'); @@ -38,7 +38,7 @@ assert.throws(() => { global.hello = 5; script = new Script('hello = 2'); script.runInThisContext(script); -assert.strictEqual(2, global.hello); +assert.strictEqual(global.hello, 2); // Pass values @@ -49,15 +49,15 @@ global.foo = 2; global.obj = { foo: 0, baz: 3 }; script = new Script(global.code); script.runInThisContext(script); -assert.strictEqual(0, global.obj.foo); -assert.strictEqual(2, global.bar); -assert.strictEqual(1, global.foo); +assert.strictEqual(global.obj.foo, 0); +assert.strictEqual(global.bar, 2); +assert.strictEqual(global.foo, 1); // Call a function global.f = function() { global.foo = 100; }; script = new Script('f()'); script.runInThisContext(script); -assert.strictEqual(100, global.foo); +assert.strictEqual(global.foo, 100); common.allowGlobals( global.hello,