From 4259afe583a06f180a843d9559f8327c3c095ff1 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Tue, 7 Jan 2020 14:18:56 +0100 Subject: [PATCH] src: remove node::InitializeV8Platform() This API method was introduced in commit 90ae4bd0c9 ("src: add InitializeV8Platform function") from July 2018 but wasn't properly exported and therefore not usable on Windows or with shared library builds. The motivation from the commit log is mainly about making it easier to wire up the cctests and there are better ways to do that. Refs: https://github.com/nodejs/node/pull/31217 PR-URL: https://github.com/nodejs/node/pull/31245 Reviewed-By: David Carlier Reviewed-By: Rich Trott Reviewed-By: Anna Henningsen --- src/api/environment.cc | 5 ----- src/node.h | 1 - 2 files changed, 6 deletions(-) diff --git a/src/api/environment.cc b/src/api/environment.cc index 95ef13dfb1f4e6..df12331308f399 100644 --- a/src/api/environment.cc +++ b/src/api/environment.cc @@ -366,11 +366,6 @@ MultiIsolatePlatform* CreatePlatform( return new NodePlatform(thread_pool_size, tracing_controller); } -MultiIsolatePlatform* InitializeV8Platform(int thread_pool_size) { - per_process::v8_platform.Initialize(thread_pool_size); - return per_process::v8_platform.Platform(); -} - void FreePlatform(MultiIsolatePlatform* platform) { delete platform; } diff --git a/src/node.h b/src/node.h index e410068e45dc01..9e35b66ff419e2 100644 --- a/src/node.h +++ b/src/node.h @@ -389,7 +389,6 @@ NODE_EXTERN MultiIsolatePlatform* GetMainThreadMultiIsolatePlatform(); NODE_EXTERN MultiIsolatePlatform* CreatePlatform( int thread_pool_size, node::tracing::TracingController* tracing_controller); -MultiIsolatePlatform* InitializeV8Platform(int thread_pool_size); NODE_EXTERN void FreePlatform(MultiIsolatePlatform* platform); NODE_EXTERN void EmitBeforeExit(Environment* env);