Skip to content

Commit

Permalink
tools: ensure doc-only doesn't update package-lock
Browse files Browse the repository at this point in the history
Currently `make doc-only` is updating the package-lock.json
which is breaking our release build.

This adds the flags `--no-package-lock` when
running `npm install` to ensure the package-lock.json is not
changed unintentionally by running make

PR-URL: #21015
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
MylesBorins committed Jun 6, 2018
1 parent afc811c commit 440e899
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ available-node = \
exit 1; \
fi;

run-npm-install = $(PWD)/$(NPM) install --production
run-npm-install = $(PWD)/$(NPM) install --production --no-package-lock

tools/doc/node_modules/js-yaml/package.json:
cd tools/doc && $(call available-node,$(run-npm-install))
Expand Down

0 comments on commit 440e899

Please sign in to comment.