From 47d311b3f07ff2c9da8035984614c9d0797d81d8 Mon Sep 17 00:00:00 2001 From: Weijia Wang Date: Wed, 24 Apr 2019 14:36:15 +0800 Subject: [PATCH] lib: remove outdated optimizations PR-URL: https://github.com/nodejs/node/pull/27380 Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Yongsheng Zhang Reviewed-By: Benedikt Meurer --- lib/internal/process/task_queues.js | 3 --- lib/timers.js | 3 --- 2 files changed, 6 deletions(-) diff --git a/lib/internal/process/task_queues.js b/lib/internal/process/task_queues.js index 309e27e6ecd0fa..28843d3fb16799 100644 --- a/lib/internal/process/task_queues.js +++ b/lib/internal/process/task_queues.js @@ -93,9 +93,6 @@ function processTicksAndRejections() { class TickObject { constructor(callback, args, triggerAsyncId) { - // This must be set to null first to avoid function tracking - // on the hidden class, revisit in V8 versions after 6.2 - this.callback = null; this.callback = callback; this.args = args; diff --git a/lib/timers.js b/lib/timers.js index ddce43e7491795..98acbf8fa44152 100644 --- a/lib/timers.js +++ b/lib/timers.js @@ -207,9 +207,6 @@ const Immediate = class Immediate { constructor(callback, args) { this._idleNext = null; this._idlePrev = null; - // This must be set to null first to avoid function tracking - // on the hidden class, revisit in V8 versions after 6.2 - this._onImmediate = null; this._onImmediate = callback; this._argv = args; this._destroyed = false;