From 47e3d00241ca69fddaa154462e81f99547533719 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 16 May 2017 10:41:36 -0700 Subject: [PATCH] test: refactor test-dns-regress-6244.js * Move from parallel to internet because it performs a DNS query * Provide link to relevant issue in comments * Remove unnecessary explicit no-op function PR-URL: https://github.com/nodejs/node/pull/13058 Reviewed-By: Anna Henningsen Reviewed-By: Santiago Gimeno Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Gibson Fahnestock --- test/{parallel => internet}/test-dns-regress-6244.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) rename test/{parallel => internet}/test-dns-regress-6244.js (90%) diff --git a/test/parallel/test-dns-regress-6244.js b/test/internet/test-dns-regress-6244.js similarity index 90% rename from test/parallel/test-dns-regress-6244.js rename to test/internet/test-dns-regress-6244.js index 957d3cb672e1d3..8b10e4d7ef9008 100644 --- a/test/parallel/test-dns-regress-6244.js +++ b/test/internet/test-dns-regress-6244.js @@ -23,5 +23,6 @@ const common = require('../common'); const dns = require('dns'); -// Should not segfault, see #6244. -dns.resolve4('127.0.0.1', common.mustCall(() => { })); +// Should not segfault. +// Ref: https://github.com/nodejs/node-v0.x-archive/issues/6244 +dns.resolve4('127.0.0.1', common.mustCall());