From 4958501ac00134545a630e09bac702f6d74dc479 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Mon, 16 Jul 2018 20:45:16 +0200 Subject: [PATCH] test: remove timeout from test-pipe-stream The timeout is unnecessary and the suspected cause of the following failure (even though I could not reproduce it locally): 11:53:54 not ok 197 parallel/test-pipe-stream 11:53:54 --- 11:53:54 duration_ms: 6.253 11:53:54 severity: fail 11:53:54 exitcode: 1 11:53:54 stack: |- 11:53:54 assert.js:338 11:53:54 throw err; 11:53:54 ^ 11:53:54 11:53:54 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value: 11:53:54 11:53:54 assert.ok(have_ping) 11:53:54 11:53:54 at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12) 11:53:54 at Server. (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5) 11:53:54 at Server.emit (events.js:182:13) 11:53:54 at emitCloseNT (net.js:1668:8) 11:53:54 at process._tickCallback (internal/process/next_tick.js:63:19) (From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.) PR-URL: https://github.com/nodejs/node/pull/21837 Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- test/parallel/test-pipe-stream.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/parallel/test-pipe-stream.js b/test/parallel/test-pipe-stream.js index c7d9a0a626559e..c697530c0d5d81 100644 --- a/test/parallel/test-pipe-stream.js +++ b/test/parallel/test-pipe-stream.js @@ -49,15 +49,10 @@ function test(clazz, cb) { }); } - const timeout = setTimeout(function() { - server.close(); - }, 2000); - const server = net.Server(); server.listen(common.PIPE, ping); server.on('connection', pong); server.on('close', function() { - clearTimeout(timeout); check(); cb && cb(); });