Skip to content

Commit 49c5ea1

Browse files
committed
test: fix validation error assertions in child_process
1 parent bb46bec commit 49c5ea1

File tree

4 files changed

+28
-26
lines changed

4 files changed

+28
-26
lines changed

test/parallel/test-child-process-fork-timeout-kill-signal.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ const { getEventListeners } = require('events');
2727
// Verify timeout verification
2828
throws(() => fork(fixtures.path('child-process-stay-alive-forever.js'), {
2929
timeout: 'badValue',
30-
}), /ERR_OUT_OF_RANGE/);
30+
}), /ERR_INVALID_ARG_TYPE/);
3131

3232
throws(() => fork(fixtures.path('child-process-stay-alive-forever.js'), {
3333
timeout: {},
34-
}), /ERR_OUT_OF_RANGE/);
34+
}), /ERR_INVALID_ARG_TYPE/);
3535
}
3636

3737
{

test/parallel/test-child-process-spawn-timeout-kill-signal.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ const aliveForeverFile = 'child-process-stay-alive-forever.js';
2828
// Verify timeout verification
2929
throws(() => spawn(process.execPath, [fixtures.path(aliveForeverFile)], {
3030
timeout: 'badValue',
31-
}), /ERR_OUT_OF_RANGE/);
31+
}), /ERR_INVALID_ARG_TYPE/);
3232

3333
throws(() => spawn(process.execPath, [fixtures.path(aliveForeverFile)], {
3434
timeout: {},
35-
}), /ERR_OUT_OF_RANGE/);
35+
}), /ERR_INVALID_ARG_TYPE/);
3636
}
3737

3838
{

test/parallel/test-child-process-spawn-typeerror.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ const invalidArgTypeError = {
3939
name: 'TypeError'
4040
};
4141

42+
const invalidRangeError = { code: 'ERR_OUT_OF_RANGE', name: 'RangeError' };
43+
4244
assert.throws(function() {
4345
spawn(invalidcmd, 'this is not an array');
4446
}, invalidArgTypeError);
@@ -77,11 +79,11 @@ assert.throws(function() {
7779

7880
assert.throws(function() {
7981
spawn(cmd, [], { uid: 2 ** 63 });
80-
}, invalidArgTypeError);
82+
}, invalidRangeError);
8183

8284
assert.throws(function() {
8385
spawn(cmd, [], { gid: 2 ** 63 });
84-
}, invalidArgTypeError);
86+
}, invalidRangeError);
8587

8688
// Argument types for combinatorics.
8789
const a = [];

test/parallel/test-child-process-spawnsync-validation-errors.js

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ if (!common.isWindows) {
6464
fail('uid', [], invalidArgTypeError);
6565
fail('uid', {}, invalidArgTypeError);
6666
fail('uid', common.mustNotCall(), invalidArgTypeError);
67-
fail('uid', NaN, invalidArgTypeError);
68-
fail('uid', Infinity, invalidArgTypeError);
69-
fail('uid', 3.1, invalidArgTypeError);
70-
fail('uid', -3.1, invalidArgTypeError);
67+
fail('uid', NaN, invalidRangeError);
68+
fail('uid', Infinity, invalidRangeError);
69+
fail('uid', 3.1, invalidRangeError);
70+
fail('uid', -3.1, invalidRangeError);
7171
}
7272
}
7373

@@ -83,10 +83,10 @@ if (!common.isWindows) {
8383
fail('gid', [], invalidArgTypeError);
8484
fail('gid', {}, invalidArgTypeError);
8585
fail('gid', common.mustNotCall(), invalidArgTypeError);
86-
fail('gid', NaN, invalidArgTypeError);
87-
fail('gid', Infinity, invalidArgTypeError);
88-
fail('gid', 3.1, invalidArgTypeError);
89-
fail('gid', -3.1, invalidArgTypeError);
86+
fail('gid', NaN, invalidRangeError);
87+
fail('gid', Infinity, invalidRangeError);
88+
fail('gid', 3.1, invalidRangeError);
89+
fail('gid', -3.1, invalidRangeError);
9090
}
9191
}
9292
}
@@ -152,12 +152,12 @@ if (!common.isWindows) {
152152
pass('timeout', 1);
153153
pass('timeout', 0);
154154
fail('timeout', -1, invalidRangeError);
155-
fail('timeout', true, invalidRangeError);
156-
fail('timeout', false, invalidRangeError);
157-
fail('timeout', __dirname, invalidRangeError);
158-
fail('timeout', [], invalidRangeError);
159-
fail('timeout', {}, invalidRangeError);
160-
fail('timeout', common.mustNotCall(), invalidRangeError);
155+
fail('timeout', true, invalidArgTypeError);
156+
fail('timeout', false, invalidArgTypeError);
157+
fail('timeout', __dirname, invalidArgTypeError);
158+
fail('timeout', [], invalidArgTypeError);
159+
fail('timeout', {}, invalidArgTypeError);
160+
fail('timeout', common.mustNotCall(), invalidArgTypeError);
161161
fail('timeout', NaN, invalidRangeError);
162162
fail('timeout', Infinity, invalidRangeError);
163163
fail('timeout', 3.1, invalidRangeError);
@@ -175,12 +175,12 @@ if (!common.isWindows) {
175175
fail('maxBuffer', -1, invalidRangeError);
176176
fail('maxBuffer', NaN, invalidRangeError);
177177
fail('maxBuffer', -Infinity, invalidRangeError);
178-
fail('maxBuffer', true, invalidRangeError);
179-
fail('maxBuffer', false, invalidRangeError);
180-
fail('maxBuffer', __dirname, invalidRangeError);
181-
fail('maxBuffer', [], invalidRangeError);
182-
fail('maxBuffer', {}, invalidRangeError);
183-
fail('maxBuffer', common.mustNotCall(), invalidRangeError);
178+
fail('maxBuffer', true, invalidArgTypeError);
179+
fail('maxBuffer', false, invalidArgTypeError);
180+
fail('maxBuffer', __dirname, invalidArgTypeError);
181+
fail('maxBuffer', [], invalidArgTypeError);
182+
fail('maxBuffer', {}, invalidArgTypeError);
183+
fail('maxBuffer', common.mustNotCall(), invalidArgTypeError);
184184
}
185185

186186
{

0 commit comments

Comments
 (0)