Skip to content

Commit

Permalink
repl: remove deprecated bufferedCommand property
Browse files Browse the repository at this point in the history
This property is deprecated since Node.js v9.0.0 and to improve
maintainability of the REPL it is now removed.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
BridgeAR committed May 23, 2020
1 parent 3752430 commit 4ace010
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
5 changes: 4 additions & 1 deletion doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -1547,12 +1547,15 @@ code, no replacement API is provided.
### DEP0074: `REPLServer.bufferedCommand`
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/33286
description: End-of-Life.
- version: v9.0.0
pr-url: https://github.com/nodejs/node/pull/13687
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

The `REPLServer.bufferedCommand` property was deprecated in favor of
[`REPLServer.clearBufferedCommand()`][].
Expand Down
9 changes: 0 additions & 9 deletions lib/repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -626,15 +626,6 @@ function REPLServer(prompt,
});

self.clearBufferedCommand();
ObjectDefineProperty(this, 'bufferedCommand', {
get: deprecate(() => self[kBufferedCommandSymbol],
'REPLServer.bufferedCommand is deprecated',
'DEP0074'),
set: deprecate((val) => self[kBufferedCommandSymbol] = val,
'REPLServer.bufferedCommand is deprecated',
'DEP0074'),
enumerable: true
});

function completer(text, cb) {
complete.call(self, text, self.editorMode ?
Expand Down

0 comments on commit 4ace010

Please sign in to comment.