From 4d984ecadbf87c11be854bc56c78782f8770f62d Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 29 Dec 2016 21:19:36 -0800 Subject: [PATCH] test: refactor test-stream-pipe-error-handling * provide a RegExp for second argument to `assert.throws()` * remove unused function arguments * provide duration of 1 ms for `setTimeout()` calls that do not have a duration PR-URL: https://github.com/nodejs/node/pull/10530 Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig --- test/parallel/test-stream-pipe-error-handling.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-stream-pipe-error-handling.js b/test/parallel/test-stream-pipe-error-handling.js index 3b36768805c9ec..db79f6e5f36c70 100644 --- a/test/parallel/test-stream-pipe-error-handling.js +++ b/test/parallel/test-stream-pipe-error-handling.js @@ -50,8 +50,8 @@ const Stream = require('stream').Stream; assert(removed); assert.throws(function() { w.emit('error', new Error('fail')); - }); - })); + }, /^Error: fail$/); + }), 1); }); w.on('error', myOnError); @@ -59,7 +59,7 @@ const Stream = require('stream').Stream; w.removeListener('error', myOnError); removed = true; - function myOnError(er) { + function myOnError() { throw new Error('this should not happen'); } } @@ -76,10 +76,10 @@ const Stream = require('stream').Stream; setTimeout(common.mustCall(function() { assert(removed); w.emit('error', new Error('fail')); - })); + }), 1); }); - w.on('error', common.mustCall(function(er) {})); + w.on('error', common.mustCall(function() {})); w._write = function() {}; r.pipe(w);