From 4deb23a2f66e576be96c3bb856e5199cb3439865 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 2 Feb 2019 06:07:00 -0800 Subject: [PATCH] tools: improve prerequisites for test-all-suites The prerequisistes for test-all-suites were running some tests themselves. When one of those tests failed during a coverage run, it resulted in artificially low coverage. Fix the prerequisites to only build stuff, not test. PR-URL: https://github.com/nodejs/node/pull/25892 Reviewed-By: Refael Ackermann Reviewed-By: Anna Henningsen --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index da159b6859607f..c3c9bdf6f765e4 100644 --- a/Makefile +++ b/Makefile @@ -467,7 +467,7 @@ test-all-valgrind: test-build $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release --valgrind .PHONY: test-all-suites -test-all-suites: test-build test-js-native-api test-node-api | bench-addons-build ## Run all test suites. +test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run all test suites. $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/* CI_NATIVE_SUITES ?= addons js-native-api node-api