From 52de27b9fe096e6c7f2a0b9fd1cb992d3a3624eb Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 20 Jun 2023 20:45:07 -0700 Subject: [PATCH] tools: pin ruff version number MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit New versions have new rules and end up breaking builds unexpectedly. PR-URL: https://github.com/nodejs/node/pull/48505 Reviewed-By: Juan José Arboleda Reviewed-By: Richard Lau Reviewed-By: Benjamin Gruenbaum Reviewed-By: Moshe Atlow Reviewed-By: Ruy Adorno Reviewed-By: Yagiz Nizipli Reviewed-By: Geoffrey Booth Reviewed-By: Luigi Pinca --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index b0a0b8a9fc106b..b1c267ed5526fe 100644 --- a/Makefile +++ b/Makefile @@ -1495,8 +1495,8 @@ cpplint: lint-cpp # Try with '--system' if it fails without; the system may have set '--user' lint-py-build: $(info Pip installing ruff on $(shell $(PYTHON) --version)...) - $(PYTHON) -m pip install --upgrade --target tools/pip/site-packages ruff || \ - $(PYTHON) -m pip install --upgrade --system --target tools/pip/site-packages ruff + $(PYTHON) -m pip install --upgrade --target tools/pip/site-packages ruff==0.0.272 || \ + $(PYTHON) -m pip install --upgrade --system --target tools/pip/site-packages ruff==0.0.272 .PHONY: lint-py ifneq ("","$(wildcard tools/pip/site-packages/ruff)")