From 55a8ca8ee4dbc1ed5d8dd57036e1f0a9b091754b Mon Sep 17 00:00:00 2001 From: RamanandPatil Date: Mon, 2 Mar 2020 17:03:55 +0530 Subject: [PATCH] src: elevate v8 namespace PR-URL: https://github.com/nodejs/node/pull/32041 Reviewed-By: James M Snell Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Gireesh Punathil Reviewed-By: Ruben Bridgewater --- src/cares_wrap.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc index 8abf662caa3142..71d8f8569ba5f4 100644 --- a/src/cares_wrap.cc +++ b/src/cares_wrap.cc @@ -64,6 +64,7 @@ using v8::FunctionTemplate; using v8::HandleScope; using v8::Int32; using v8::Integer; +using v8::Isolate; using v8::Local; using v8::Null; using v8::Object; @@ -1917,7 +1918,7 @@ int ParseIP(const char* ip, ParseIPResult* result = nullptr) { } void CanonicalizeIP(const FunctionCallbackInfo& args) { - v8::Isolate* isolate = args.GetIsolate(); + Isolate* isolate = args.GetIsolate(); node::Utf8Value ip(isolate, args[0]); ParseIPResult result; @@ -1927,7 +1928,7 @@ void CanonicalizeIP(const FunctionCallbackInfo& args) { char canonical_ip[INET6_ADDRSTRLEN]; const int af = (rc == 4 ? AF_INET : AF_INET6); CHECK_EQ(0, uv_inet_ntop(af, &result, canonical_ip, sizeof(canonical_ip))); - v8::Local val = String::NewFromUtf8(isolate, canonical_ip, + Local val = String::NewFromUtf8(isolate, canonical_ip, v8::NewStringType::kNormal).ToLocalChecked(); args.GetReturnValue().Set(val); }