From 5dc293d3f331497ed6c219d70b414d8f5a9fd423 Mon Sep 17 00:00:00 2001 From: Yang Guo Date: Mon, 30 Apr 2018 22:45:00 +0200 Subject: [PATCH] src: fix inconsistency in extern declaration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit NodeCounterProvider is declared as extern but defined as EXTERN_C. This confuses clang-cl. PR-URL: https://github.com/nodejs/node/pull/20436 Refs: https://github.com/nodejs/node/issues/19630 Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: Anna Henningsen Reviewed-By: Refael Ackermann Reviewed-By: Ben Noordhuis Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen --- src/node_win32_perfctr_provider.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_win32_perfctr_provider.cc b/src/node_win32_perfctr_provider.cc index aac0203d719ebc..6ec3cbd5cfae69 100644 --- a/src/node_win32_perfctr_provider.cc +++ b/src/node_win32_perfctr_provider.cc @@ -119,7 +119,7 @@ PPERF_COUNTERSET_INSTANCE perfctr_instance; namespace node { -EXTERN_C DECLSPEC_SELECTANY HANDLE NodeCounterProvider = nullptr; +HANDLE NodeCounterProvider = nullptr; void InitPerfCountersWin32() { ULONG status;