From 64cf00b0b9f08aa2616737f2ff5438352b979dfe Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 12 Nov 2019 19:50:09 -0800 Subject: [PATCH] doc: simplify text in pull-requests.md Mostly, this replaces "It is recommended to do X" with "Do X." PR-URL: https://github.com/nodejs/node/pull/30458 Reviewed-By: Richard Lau Reviewed-By: Trivikram Kamat Reviewed-By: Denys Otrishko Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater --- doc/guides/contributing/pull-requests.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 17257674a3b546..f23c92fa024e63 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -73,7 +73,7 @@ $ git remote add upstream https://github.com/nodejs/node.git $ git fetch upstream ``` -It is recommended to configure `git` so that it knows who you are: +Configure `git` so that it knows who you are: ```text $ git config user.name "J. Random User" @@ -125,7 +125,7 @@ For contributing C++ code, you may want to look at the ### Step 4: Commit -It is a recommended best practice to keep your changes as logically grouped +It is a best practice to keep your changes as logically grouped as possible within individual commits. There is no limit to the number of commits any single Pull Request may have, and many contributors find it easier to review changes that are split across multiple commits.