From 66c8f76c2c35c0762b5c9afa631beee52828f971 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= <tniessen@tnie.de>
Date: Sun, 4 Apr 2021 02:14:55 +0200
Subject: [PATCH] src: remove KeyObjectData::CreateSecret overload

This function is unused and there is not much potential for using
it in the current codebase.

PR-URL: https://github.com/nodejs/node/pull/38067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
---
 src/crypto/crypto_keys.cc | 5 -----
 src/crypto/crypto_keys.h  | 3 ---
 2 files changed, 8 deletions(-)

diff --git a/src/crypto/crypto_keys.cc b/src/crypto/crypto_keys.cc
index 4e8408086e9bff..be12022bdb7f1d 100644
--- a/src/crypto/crypto_keys.cc
+++ b/src/crypto/crypto_keys.cc
@@ -837,11 +837,6 @@ void KeyObjectData::MemoryInfo(MemoryTracker* tracker) const {
   }
 }
 
-std::shared_ptr<KeyObjectData> KeyObjectData::CreateSecret(
-    const ArrayBufferOrViewContents<char>& buf) {
-  return CreateSecret(buf.ToCopy());
-}
-
 std::shared_ptr<KeyObjectData> KeyObjectData::CreateSecret(ByteSource key) {
   CHECK(key);
   return std::shared_ptr<KeyObjectData>(new KeyObjectData(std::move(key)));
diff --git a/src/crypto/crypto_keys.h b/src/crypto/crypto_keys.h
index bf1498e62851eb..98e497a5b220c7 100644
--- a/src/crypto/crypto_keys.h
+++ b/src/crypto/crypto_keys.h
@@ -134,9 +134,6 @@ class ManagedEVPPKey : public MemoryRetainer {
 // Objects of this class can safely be shared among threads.
 class KeyObjectData : public MemoryRetainer {
  public:
-  static std::shared_ptr<KeyObjectData> CreateSecret(
-      const ArrayBufferOrViewContents<char>& buf);
-
   static std::shared_ptr<KeyObjectData> CreateSecret(ByteSource key);
 
   static std::shared_ptr<KeyObjectData> CreateAsymmetric(