From 6c41f33571ab626bcced79a79d673d687a69d7d2 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 15 Jun 2018 15:37:47 -0700 Subject: [PATCH] doc: wrap pull-requests.md at 80 characters PR-URL: https://github.com/nodejs/node/pull/21361 Reviewed-By: Richard Lau Reviewed-By: Refael Ackermann Reviewed-By: Jon Moss Reviewed-By: Vse Mozhet Byt Reviewed-By: Luigi Pinca --- doc/guides/contributing/pull-requests.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 0da7022d101ed5..0ae30d5b7710ec 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -137,8 +137,8 @@ notes about [commit squashing](#commit-squashing)). A good commit message should describe what changed and why. 1. The first line should: - - contain a short description of the change (preferably 50 characters or less, - and no more than 72 characters) + - contain a short description of the change (preferably 50 characters or + less, and no more than 72 characters) - be entirely in lowercase with the exception of proper nouns, acronyms, and the words that refer to code, like function/variable names - be prefixed with the name of the changed subsystem and start with an @@ -456,7 +456,8 @@ Focus first on the most significant aspects of the change: 1. Does this change make sense for Node.js? 2. Does this change make Node.js better, even if only incrementally? 3. Are there clear bugs or larger scale issues that need attending to? -4. Is the commit message readable and correct? If it contains a breaking change is it clear enough? +4. Is the commit message readable and correct? If it contains a breaking change + is it clear enough? When changes are necessary, *request* them, do not *demand* them, and do not assume that the submitter already knows how to add a test or run a benchmark.