From 6d6bd2dc3be6e6d6ea632f5272de9d7915b41459 Mon Sep 17 00:00:00 2001 From: Mary Marchini Date: Fri, 7 Aug 2020 12:30:44 -0700 Subject: [PATCH] meta: uncomment all codeowners A recent feature was added to github-bot to ping codeowners defined on the CODEOWNERS file even if the team doesn't have write permission to the repository. That means we can enable codeowners everywhere in the repository. Ref: https://github.com/nodejs/github-bot/pull/265 Fix: https://github.com/nodejs/node/issues/33984 PR-URL: https://github.com/nodejs/node/pull/34670 Fixes: https://github.com/nodejs/node/issues/33984 Refs: https://github.com/nodejs/github-bot/pull/265 Reviewed-By: James M Snell Reviewed-By: Denys Otrishko Reviewed-By: Matteo Collina --- .github/CODEOWNERS | 98 +++++++++++++++++++++++----------------------- 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 2413b5e89f646a..247b5c17b54805 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -5,57 +5,57 @@ # 3. PRs touching any code with a codeowner must be signed off by at least one # person on the code owner team. -./.github/CODEOWNERS @nodejs/tsc +/.github/CODEOWNERS @nodejs/tsc # net -# ./deps/cares @nodejs/net -# ./doc/api/dns.md @nodejs/net -# ./doc/api/dgram.md @nodejs/net -# ./doc/api/net.md @nodejs/net -# ./lib/dgram.js @nodejs/net -# ./lib/dns.js @nodejs/net -# ./lib/net.js @nodejs/net @nodejs/quic -# ./lib/internal/dgram.js @nodejs/net -# ./lib/internal/dns/* @nodejs/net -# ./lib/internal/net.js @nodejs/net -# ./lib/internal/socket_list.js @nodejs/net -# ./lib/internal/js_stream_socket.js @nodejs/net -# ./src/cares_wrap.h @nodejs/net -# ./src/connect_wrap.* @nodejs/net -# ./src/connection_wrap.* @nodejs/net -# ./src/node_sockaddr* @nodejs/net -# ./src/tcp_wrap.* @nodejs/net -# ./src/udp_wrap.* @nodejs/net +/deps/cares @nodejs/net +/doc/api/dns.md @nodejs/net +/doc/api/dgram.md @nodejs/net +/doc/api/net.md @nodejs/net +/lib/dgram.js @nodejs/net +/lib/dns.js @nodejs/net +/lib/net.js @nodejs/net @nodejs/quic +/lib/internal/dgram.js @nodejs/net +/lib/internal/dns/* @nodejs/net +/lib/internal/net.js @nodejs/net +/lib/internal/socket_list.js @nodejs/net +/lib/internal/js_stream_socket.js @nodejs/net +/src/cares_wrap.h @nodejs/net +/src/connect_wrap.* @nodejs/net +/src/connection_wrap.* @nodejs/net +/src/node_sockaddr* @nodejs/net +/src/tcp_wrap.* @nodejs/net +/src/udp_wrap.* @nodejs/net # tls/crypto -# ./lib/internal/crypto/* @nodejs/crypto -# ./lib/internal/tls.js @nodejs/crypto @nodejs/net -# ./lib/crypto.js @nodejs/crypto -# ./lib/tls.js @nodejs/crypto @nodejs/net -# ./src/node_crypto* @nodejs/crypto -# ./src/node_crypto_common* @nodejs/crypto @nodejs/quic +/lib/internal/crypto/* @nodejs/crypto +/lib/internal/tls.js @nodejs/crypto @nodejs/net +/lib/crypto.js @nodejs/crypto +/lib/tls.js @nodejs/crypto @nodejs/net +/src/node_crypto* @nodejs/crypto +/src/node_crypto_common* @nodejs/crypto @nodejs/quic # http -# ./deps/llhttp/* @nodejs/http @nodejs/net -# ./doc/api/http.md @nodejs/http @nodejs/net -# ./doc/api/http2.md @nodejs/http @nodejs/net -# ./lib/_http_* @nodejs/http @nodejs/net -# ./lib/http.js @nodejs/http @nodejs/net -# ./lib/https.js @nodejs/crypto @nodejs/net @nodejs/http -# ./src/node_http_common* @nodejs/http @nodejs/http2 @nodejs/quic @nodejs/net -# ./src/node_http_parser.cc @nodejs/http @nodejs/net +/deps/llhttp/* @nodejs/http @nodejs/net +/doc/api/http.md @nodejs/http @nodejs/net +/doc/api/http2.md @nodejs/http @nodejs/net +/lib/_http_* @nodejs/http @nodejs/net +/lib/http.js @nodejs/http @nodejs/net +/lib/https.js @nodejs/crypto @nodejs/net @nodejs/http +/src/node_http_common* @nodejs/http @nodejs/http2 @nodejs/quic @nodejs/net +/src/node_http_parser.cc @nodejs/http @nodejs/net # http2 -./deps/nghttp2/* @nodejs/http2 @nodejs/net -./doc/api/http2.md @nodejs/http2 @nodejs/net -./lib/http2.js @nodejs/http2 @nodejs/net -./lib/internal/http2/* @nodejs/http2 @nodejs/net -./src/node_http2* @nodejs/http2 @nodejs/net -./src/node_mem* @nodejs/http2 +/deps/nghttp2/* @nodejs/http2 @nodejs/net +/doc/api/http2.md @nodejs/http2 @nodejs/net +/lib/http2.js @nodejs/http2 @nodejs/net +/lib/internal/http2/* @nodejs/http2 @nodejs/net +/src/node_http2* @nodejs/http2 @nodejs/net +/src/node_mem* @nodejs/http2 # quic @@ -68,16 +68,16 @@ # modules -# ./doc/api/modules.md @nodejs/modules -# ./doc/api/esm.md @nodejs/modules -# ./lib/module.js @nodejs/modules -# ./lib/internal/modules/* @nodejs/modules -# ./lib/internal/bootstrap/loaders.js @nodejs/modules -# ./src/module_wrap* @nodejs/modules @nodejs/vm +/doc/api/modules.md @nodejs/modules +/doc/api/esm.md @nodejs/modules +/lib/module.js @nodejs/modules +/lib/internal/modules/* @nodejs/modules +/lib/internal/bootstrap/loaders.js @nodejs/modules +/src/module_wrap* @nodejs/modules @nodejs/vm # N-API -# /src/node_api* @nodejs/n-api -# /src/js_native_api* @nodejs/n-api -# /doc/guides/adding-new-napi-api.md @nodejs/n-api -# /doc/api/n-api.md @nodejs/n-api +/src/node_api* @nodejs/n-api +/src/js_native_api* @nodejs/n-api +/doc/guides/adding-new-napi-api.md @nodejs/n-api +/doc/api/n-api.md @nodejs/n-api