From 6dfe7aeed59f6afb2ae6180f4699a6b937d2cfd1 Mon Sep 17 00:00:00 2001 From: Gireesh Punathil Date: Wed, 20 Apr 2016 11:23:19 -0400 Subject: [PATCH] cares: Support malloc(0) scenarios for AIX Many places in cares library, when the stream data arrives from the network with respect to dns and reverse dns resolution, they are populated into data structures created dymaically based on the size of the data. Malloc is heavily used for such cases. Often, based on the data length, malloc(0) is invoked. Linux behavior on zero byte allocation is to return a valid pointer where in AIX, it always return NULL. This manifestst as test failure of test/internet/test-dns.js Solution is to build cares with Linux compatible malloc behavior PR-URL: https://github.com/nodejs/node/pull/6305 Reviewed-By: James M Snell Reviewed-By: Ben Noordhuis Reviewed-by: Michael Dawson --- deps/cares/cares.gyp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/deps/cares/cares.gyp b/deps/cares/cares.gyp index 8a5239b4129623..745e38e33d2d6b 100644 --- a/deps/cares/cares.gyp +++ b/deps/cares/cares.gyp @@ -12,6 +12,10 @@ [ 'OS=="aix"', { 'include_dirs': [ 'config/aix' ], 'sources': [ 'config/aix/ares_config.h' ], + 'defines': [ + # Support for malloc(0) + '_LINUX_SOURCE_COMPAT=1', + '_ALL_SOURCE=1'], }], ['OS=="solaris"', { 'defines': [