From 6f95f01f958059624bc8d50fe006417a0009344d Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Thu, 9 Jan 2020 22:47:56 +0100 Subject: [PATCH] deps: deactivate failing tests corresponding to experimental features MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This comments out three tests that consistently fail on v13.x. The test can be activated again in case the necessary code change lands on v13.x for the tests to pass. PR-URL: https://github.com/nodejs/node/pull/31289 Reviewed-By: Anna Henningsen Reviewed-By: Michaël Zasso Reviewed-By: Richard Lau --- .../interpreter/test-bytecode-generator.cc | 292 +++++++++--------- 1 file changed, 146 insertions(+), 146 deletions(-) diff --git a/deps/v8/test/cctest/interpreter/test-bytecode-generator.cc b/deps/v8/test/cctest/interpreter/test-bytecode-generator.cc index be0b129418707b..1bca486e13640a 100644 --- a/deps/v8/test/cctest/interpreter/test-bytecode-generator.cc +++ b/deps/v8/test/cctest/interpreter/test-bytecode-generator.cc @@ -2884,129 +2884,129 @@ TEST(PrivateAccessorAccess) { i::FLAG_harmony_private_methods = old_methods_flag; } -TEST(StaticPrivateMethodDeclaration) { - bool old_methods_flag = i::FLAG_harmony_private_methods; - i::FLAG_harmony_private_methods = true; - InitializedIgnitionHandleScope scope; - BytecodeExpectationsPrinter printer(CcTest::isolate()); - - const char* snippets[] = { - "{\n" - " class A {\n" - " static #a() { return 1; }\n" - " }\n" - "}\n", - - "{\n" - " class A {\n" - " static get #a() { return 1; }\n" - " }\n" - "}\n", - - "{\n" - " class A {\n" - " static set #a(val) { }\n" - " }\n" - "}\n", - - "{\n" - " class A {\n" - " static get #a() { return 1; }\n" - " static set #a(val) { }\n" - " }\n" - "}\n", - - "{\n" - " class A {\n" - " static #a() { }\n" - " #b() { }\n" - " }\n" - "}\n"}; - - CHECK(CompareTexts(BuildActual(printer, snippets), - LoadGolden("StaticPrivateMethodDeclaration.golden"))); - i::FLAG_harmony_private_methods = old_methods_flag; -} - -TEST(StaticPrivateMethodAccess) { - bool old_methods_flag = i::FLAG_harmony_private_methods; - i::FLAG_harmony_private_methods = true; - InitializedIgnitionHandleScope scope; - BytecodeExpectationsPrinter printer(CcTest::isolate()); - printer.set_wrap(false); - printer.set_test_function_name("test"); - - const char* snippets[] = { - "class A {\n" - " static #a() { return 1; }\n" - " static test() { return this.#a(); }\n" - "}\n" - "\n" - "var test = A.test;\n" - "test();\n", - - "class B {\n" - " static #b() { return 1; }\n" - " static test() { this.#b = 1; }\n" - "}\n" - "\n" - "var test = B.test;\n" - "test();\n", - - "class C {\n" - " static #c() { return 1; }\n" - " static test() { this.#c++; }\n" - "}\n" - "\n" - "var test = C.test;\n" - "test();\n", - - "class D {\n" - " static get #d() { return 1; }\n" - " static set #d(val) { }\n" - "\n" - " static test() {\n" - " this.#d++;\n" - " this.#d = 1;\n" - " return this.#d;\n" - " }\n" - "}\n" - "\n" - "var test = D.test;\n" - "test();\n", - - "class E {\n" - " static get #e() { return 1; }\n" - " static test() { this.#e++; }\n" - "}\n" - "var test = E.test;\n" - "test();\n", - - "class F {\n" - " static set #f(val) { }\n" - " static test() { this.#f++; }\n" - "}\n" - "var test = F.test;\n" - "test();\n", - - "class G {\n" - " static get #d() { return 1; }\n" - " static test() { this.#d = 1; }\n" - "}\n" - "var test = G.test;\n" - "test();\n", - - "class H {\n" - " set #h(val) { }\n" - " static test() { this.#h; }\n" - "}\n" - "var test = H.test;\n" - "test();\n"}; - - CHECK(CompareTexts(BuildActual(printer, snippets), - LoadGolden("StaticPrivateMethodAccess.golden"))); - i::FLAG_harmony_private_methods = old_methods_flag; -} +// TEST(StaticPrivateMethodDeclaration) { +// bool old_methods_flag = i::FLAG_harmony_private_methods; +// i::FLAG_harmony_private_methods = true; +// InitializedIgnitionHandleScope scope; +// BytecodeExpectationsPrinter printer(CcTest::isolate()); + +// const char* snippets[] = { +// "{\n" +// " class A {\n" +// " static #a() { return 1; }\n" +// " }\n" +// "}\n", + +// "{\n" +// " class A {\n" +// " static get #a() { return 1; }\n" +// " }\n" +// "}\n", + +// "{\n" +// " class A {\n" +// " static set #a(val) { }\n" +// " }\n" +// "}\n", + +// "{\n" +// " class A {\n" +// " static get #a() { return 1; }\n" +// " static set #a(val) { }\n" +// " }\n" +// "}\n", + +// "{\n" +// " class A {\n" +// " static #a() { }\n" +// " #b() { }\n" +// " }\n" +// "}\n"}; + +// CHECK(CompareTexts(BuildActual(printer, snippets), +// LoadGolden("StaticPrivateMethodDeclaration.golden"))); +// i::FLAG_harmony_private_methods = old_methods_flag; +// } + +// TEST(StaticPrivateMethodAccess) { +// bool old_methods_flag = i::FLAG_harmony_private_methods; +// i::FLAG_harmony_private_methods = true; +// InitializedIgnitionHandleScope scope; +// BytecodeExpectationsPrinter printer(CcTest::isolate()); +// printer.set_wrap(false); +// printer.set_test_function_name("test"); + +// const char* snippets[] = { +// "class A {\n" +// " static #a() { return 1; }\n" +// " static test() { return this.#a(); }\n" +// "}\n" +// "\n" +// "var test = A.test;\n" +// "test();\n", + +// "class B {\n" +// " static #b() { return 1; }\n" +// " static test() { this.#b = 1; }\n" +// "}\n" +// "\n" +// "var test = B.test;\n" +// "test();\n", + +// "class C {\n" +// " static #c() { return 1; }\n" +// " static test() { this.#c++; }\n" +// "}\n" +// "\n" +// "var test = C.test;\n" +// "test();\n", + +// "class D {\n" +// " static get #d() { return 1; }\n" +// " static set #d(val) { }\n" +// "\n" +// " static test() {\n" +// " this.#d++;\n" +// " this.#d = 1;\n" +// " return this.#d;\n" +// " }\n" +// "}\n" +// "\n" +// "var test = D.test;\n" +// "test();\n", + +// "class E {\n" +// " static get #e() { return 1; }\n" +// " static test() { this.#e++; }\n" +// "}\n" +// "var test = E.test;\n" +// "test();\n", + +// "class F {\n" +// " static set #f(val) { }\n" +// " static test() { this.#f++; }\n" +// "}\n" +// "var test = F.test;\n" +// "test();\n", + +// "class G {\n" +// " static get #d() { return 1; }\n" +// " static test() { this.#d = 1; }\n" +// "}\n" +// "var test = G.test;\n" +// "test();\n", + +// "class H {\n" +// " set #h(val) { }\n" +// " static test() { this.#h; }\n" +// "}\n" +// "var test = H.test;\n" +// "test();\n"}; + +// CHECK(CompareTexts(BuildActual(printer, snippets), +// LoadGolden("StaticPrivateMethodAccess.golden"))); +// i::FLAG_harmony_private_methods = old_methods_flag; +// } TEST(PrivateAccessorDeclaration) { bool old_methods_flag = i::FLAG_harmony_private_methods; @@ -3222,34 +3222,34 @@ TEST(Modules) { LoadGolden("Modules.golden"))); } -TEST(AsyncModules) { - bool previous_top_level_await_flag = i::FLAG_harmony_top_level_await; - i::FLAG_harmony_top_level_await = true; - InitializedIgnitionHandleScope scope; - BytecodeExpectationsPrinter printer(CcTest::isolate()); - printer.set_wrap(false); - printer.set_module(true); - printer.set_top_level(true); +// TEST(AsyncModules) { +// bool previous_top_level_await_flag = i::FLAG_harmony_top_level_await; +// i::FLAG_harmony_top_level_await = true; +// InitializedIgnitionHandleScope scope; +// BytecodeExpectationsPrinter printer(CcTest::isolate()); +// printer.set_wrap(false); +// printer.set_module(true); +// printer.set_top_level(true); - const char* snippets[] = { - "await 42;\n", +// const char* snippets[] = { +// "await 42;\n", - "await import(\"foo\");\n", +// "await import(\"foo\");\n", - "await 42;\n" - "async function foo() {\n" - " await 42;\n" - "}\n" - "foo();\n", +// "await 42;\n" +// "async function foo() {\n" +// " await 42;\n" +// "}\n" +// "foo();\n", - "import * as foo from \"bar\";\n" - "await import(\"goo\");\n", - }; +// "import * as foo from \"bar\";\n" +// "await import(\"goo\");\n", +// }; - CHECK(CompareTexts(BuildActual(printer, snippets), - LoadGolden("AsyncModules.golden"))); - i::FLAG_harmony_top_level_await = previous_top_level_await_flag; -} +// CHECK(CompareTexts(BuildActual(printer, snippets), +// LoadGolden("AsyncModules.golden"))); +// i::FLAG_harmony_top_level_await = previous_top_level_await_flag; +// } TEST(SuperCallAndSpread) { InitializedIgnitionHandleScope scope;