From 71358223866d91a7214eff30cdff8e50a263ea3c Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Wed, 8 Aug 2018 07:41:40 +0200 Subject: [PATCH] build: make tools/doc/node_modules non-phony This commit makes the target tools/doc/node_modules a non-phony target and also adds tools/doc/package.json as a prerequisite to it to avoid running it unnecessary. This is currently causing the target test/addons/.docbuildstamp to be always be executed as it has tools/doc/node_modules as a prerequisite. PR-URL: https://github.com/nodejs/node/pull/22189 Reviewed-By: Richard Lau Reviewed-By: Franziska Hinkelmann Reviewed-By: Sam Ruby Reviewed-By: Joyee Cheung Reviewed-By: Refael Ackermann --- Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 0869a8067b503f..525e28e5efbb10 100644 --- a/Makefile +++ b/Makefile @@ -1066,8 +1066,7 @@ lint-md-build: tools/remark-cli/node_modules \ tools/doc/node_modules \ tools/remark-preset-lint-node/node_modules -.PHONY: tools/doc/node_modules -tools/doc/node_modules: +tools/doc/node_modules: tools/doc/package.json ifeq ($(node_use_openssl),true) cd tools/doc && $(call available-node,$(run-npm-install)) else