Skip to content

Commit

Permalink
test: fix common.canCreateSymLink() on non-Windows
Browse files Browse the repository at this point in the history
test/common/README.md indicates that canCreateSymlink() always returns
true on non-Windows platforms. However, prior to this commit, undefined
was being returned. This commit aligns the implementation with the
docs by returning true.

PR-URL: #20511
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
Masashi Hirano authored and MylesBorins committed May 8, 2018
1 parent 380dfe4 commit 73f2dab
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,8 @@ exports.canCreateSymLink = function() {
return false;
}
}
// On non-Windows platforms, this always returns `true`
return true;
};

exports.getCallSite = function getCallSite(top) {
Expand Down

0 comments on commit 73f2dab

Please sign in to comment.