From 7b16597527953f436c52f0baccde77e043234e3e Mon Sep 17 00:00:00 2001
From: Matt Loring <mattloring@google.com>
Date: Fri, 4 Sep 2015 11:49:36 -0700
Subject: [PATCH] tools: fix flakiness in test-tick-processor

Per the discussion on #2471, the JS symbols checked for by this test
were occasionally too deep in the stack and were being ignored by the
tick processor.

I have addressed this by increasing the stack depth inspected by the
tick processor and looking for the eval symbol which is more likely
to be present. Additional flakiness was caused by occasional misses
of the code creation event for the JS function being executed. I now
have separate code snippets to test for JS and C++ symbols and if
the code creation event is missed for the JS symbol test then I check
for a percentage of UNKNOWN symbols in processed output. This is
considered a success as the processing scripts in the node repository
are still correctly processing the ticks recieved from the v8
scripts. Further investigation is needed into the v8 profiling
scripts to determine why code creation events are being missed.

PR-URL: https://github.com/nodejs/node/pull/2694
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
---
 test/parallel/parallel.status        |  1 -
 test/parallel/test-tick-processor.js | 50 ++++++++++++++++++----------
 2 files changed, 33 insertions(+), 18 deletions(-)

diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
index 7bb3c158d2c661..42c32d03665113 100644
--- a/test/parallel/parallel.status
+++ b/test/parallel/parallel.status
@@ -12,7 +12,6 @@ test-tls-ticket-cluster           : PASS,FLAKY
 [$system==linux]
 test-cluster-worker-forced-exit   : PASS,FLAKY
 test-http-client-timeout-event    : PASS,FLAKY
-test-tick-processor               : PASS,FLAKY
 test-tls-no-sslv3                 : PASS,FLAKY
 test-child-process-buffering      : PASS,FLAKY
 test-child-process-exit-code      : PASS,FLAKY
diff --git a/test/parallel/test-tick-processor.js b/test/parallel/test-tick-processor.js
index ebcda79d679d55..5e1cf139886bc3 100644
--- a/test/parallel/test-tick-processor.js
+++ b/test/parallel/test-tick-processor.js
@@ -6,32 +6,48 @@ var cp = require('child_process');
 var common = require('../common');
 
 common.refreshTmpDir();
-
 process.chdir(common.tmpDir);
-cp.execFileSync(process.execPath, ['-prof', '-pe',
-    'function foo(n) {' +
-    'require(\'vm\').runInDebugContext(\'Debug\');' +
-    'return n < 2 ? n : setImmediate(function() { foo(n-1) + foo(n-2);}); };' +
-    'setTimeout(function() { process.exit(0); }, 2000);' +
-    'foo(40);']);
-var matches = fs.readdirSync(common.tmpDir).filter(function(file) {
-  return /^isolate-/.test(file);
-});
-if (matches.length != 1) {
-  assert.fail('There should be a single log file.');
-}
-var log = matches[0];
 var processor =
     path.join(common.testDir, '..', 'tools', 'v8-prof', getScriptName());
-var out = cp.execSync(processor + ' ' + log, {encoding: 'utf8'});
-assert(out.match(/LazyCompile.*foo/));
+// Unknown checked for to prevent flakiness, if pattern is not found,
+// then a large number of unknown ticks should be present
+runTest(/LazyCompile.*\[eval\]:1|.*%  UNKNOWN/,
+  `function f() {
+     for (var i = 0; i < 1000000; i++) {
+       i++;
+     }
+     setImmediate(function() { f(); });
+   };
+   setTimeout(function() { process.exit(0); }, 2000);
+   f();`);
 if (process.platform === 'win32' ||
     process.platform === 'sunos' ||
     process.platform === 'freebsd') {
   console.log('1..0 # Skipped: C++ symbols are not mapped for this os.');
   return;
 }
-assert(out.match(/RunInDebugContext/));
+runTest(/RunInDebugContext/,
+  `function f() {
+     require(\'vm\').runInDebugContext(\'Debug\');
+     setImmediate(function() { f(); });
+   };
+   setTimeout(function() { process.exit(0); }, 2000);
+   f();`);
+
+function runTest(pattern, code) {
+  cp.execFileSync(process.execPath, ['-prof', '-pe', code]);
+  var matches = fs.readdirSync(common.tmpDir).filter(function(file) {
+    return /^isolate-/.test(file);
+  });
+  if (matches.length != 1) {
+    assert.fail('There should be a single log file.');
+  }
+  var log = matches[0];
+  var out = cp.execSync(processor + ' --call-graph-size=10 ' + log,
+                        {encoding: 'utf8'});
+  assert(out.match(pattern));
+  fs.unlinkSync(log);
+}
 
 function getScriptName() {
   switch (process.platform) {