From 7d71465194ae278419e9f6c0828dbd4990b8f66a Mon Sep 17 00:00:00 2001 From: Duncan Healy Date: Tue, 12 Nov 2019 16:10:22 +0000 Subject: [PATCH] test: fix flaky test-fs-stat-bigint Change test limit for atime from 2ms to 5ms. Add comment explaining why the wiggle room is needed. Fixes: https://github.com/nodejs/node/issues/24593 PR-URL: https://github.com/nodejs/node/pull/30437 Reviewed-By: Anna Henningsen Reviewed-By: Denys Otrishko Reviewed-By: Rich Trott --- test/parallel/test-fs-stat-bigint.js | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/test/parallel/test-fs-stat-bigint.js b/test/parallel/test-fs-stat-bigint.js index 998ddb289da111..811070cd9aeb99 100644 --- a/test/parallel/test-fs-stat-bigint.js +++ b/test/parallel/test-fs-stat-bigint.js @@ -13,6 +13,10 @@ tmpdir.refresh(); let testIndex = 0; +// It's possible that the file stats are updated between the two statSync() +// calls so allow for a small difference. +const allowableDelta = 5; + function getFilename() { const filename = path.join(tmpdir.path, `test-file-${++testIndex}`); fs.writeFileSync(filename, 'test'); @@ -26,8 +30,8 @@ function verifyStats(bigintStats, numStats) { const time = val.getTime(); const time2 = bigintStats[key].getTime(); assert( - Math.abs(time - time2) < 2, - `difference of ${key}.getTime() should < 2.\n` + + Math.abs(time - time2) < allowableDelta, + `difference of ${key}.getTime() should < ${allowableDelta}.\n` + `Number version ${time}, BigInt version ${time2}n`); } else if (key === 'mode') { assert.strictEqual(bigintStats[key], BigInt(val)); @@ -65,17 +69,14 @@ function verifyStats(bigintStats, numStats) { const nsFromBigInt = bigintStats[nsKey]; const msFromBigIntNs = Number(nsFromBigInt / (10n ** 6n)); const msFromNum = numStats[key]; - // The difference between the millisecond-precision values should be - // smaller than 2 + assert( - Math.abs(msFromNum - Number(msFromBigInt)) < 2, + Math.abs(msFromNum - Number(msFromBigInt)) < allowableDelta, `Number version ${key} = ${msFromNum}, ` + `BigInt version ${key} = ${msFromBigInt}n`); - // The difference between the millisecond-precision value and the - // nanosecond-precision value scaled down to milliseconds should be - // smaller than 2 + assert( - Math.abs(msFromNum - Number(msFromBigIntNs)) < 2, + Math.abs(msFromNum - Number(msFromBigIntNs)) < allowableDelta, `Number version ${key} = ${msFromNum}, ` + `BigInt version ${nsKey} = ${nsFromBigInt}n` + ` = ${msFromBigIntNs}ms`);