From 7e5e1c251526a1ee59071f0e312cb2da99454bda Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Fri, 14 Jun 2019 01:09:23 +0800 Subject: [PATCH] test: move --cpu-prof tests to sequential The tests still fail after being split into multiple files, (2 out of 30 runs in roughly 48 hours) and the causes are missing target frames in the samples. This patch moves them to sequential to observe if the flakiness can be fixed when the tests are run on a system with less load. If the flake ever shows up again even after the tests are moved to sequential, we should consider make the test conditions more lenient - that is, we would only assert that there are *some* frames in the generated CPU profile but do not look for the target function there. PR-URL: https://github.com/nodejs/node/pull/28210 Refs: https://github.com/nodejs/node/issues/27611 Reviewed-By: Rich Trott Reviewed-By: Michael Dawson Reviewed-By: James M Snell --- test/{parallel => sequential}/test-cpu-prof-default.js | 0 test/{parallel => sequential}/test-cpu-prof-dir-absolute.js | 0 test/{parallel => sequential}/test-cpu-prof-dir-and-name.js | 0 test/{parallel => sequential}/test-cpu-prof-dir-relative.js | 0 test/{parallel => sequential}/test-cpu-prof-dir-worker.js | 0 test/{parallel => sequential}/test-cpu-prof-drained.js | 0 test/{parallel => sequential}/test-cpu-prof-exit.js | 0 test/{parallel => sequential}/test-cpu-prof-invalid-options.js | 0 test/{parallel => sequential}/test-cpu-prof-kill.js | 0 test/{parallel => sequential}/test-cpu-prof-name.js | 0 test/{parallel => sequential}/test-cpu-prof-worker-argv.js | 0 11 files changed, 0 insertions(+), 0 deletions(-) rename test/{parallel => sequential}/test-cpu-prof-default.js (100%) rename test/{parallel => sequential}/test-cpu-prof-dir-absolute.js (100%) rename test/{parallel => sequential}/test-cpu-prof-dir-and-name.js (100%) rename test/{parallel => sequential}/test-cpu-prof-dir-relative.js (100%) rename test/{parallel => sequential}/test-cpu-prof-dir-worker.js (100%) rename test/{parallel => sequential}/test-cpu-prof-drained.js (100%) rename test/{parallel => sequential}/test-cpu-prof-exit.js (100%) rename test/{parallel => sequential}/test-cpu-prof-invalid-options.js (100%) rename test/{parallel => sequential}/test-cpu-prof-kill.js (100%) rename test/{parallel => sequential}/test-cpu-prof-name.js (100%) rename test/{parallel => sequential}/test-cpu-prof-worker-argv.js (100%) diff --git a/test/parallel/test-cpu-prof-default.js b/test/sequential/test-cpu-prof-default.js similarity index 100% rename from test/parallel/test-cpu-prof-default.js rename to test/sequential/test-cpu-prof-default.js diff --git a/test/parallel/test-cpu-prof-dir-absolute.js b/test/sequential/test-cpu-prof-dir-absolute.js similarity index 100% rename from test/parallel/test-cpu-prof-dir-absolute.js rename to test/sequential/test-cpu-prof-dir-absolute.js diff --git a/test/parallel/test-cpu-prof-dir-and-name.js b/test/sequential/test-cpu-prof-dir-and-name.js similarity index 100% rename from test/parallel/test-cpu-prof-dir-and-name.js rename to test/sequential/test-cpu-prof-dir-and-name.js diff --git a/test/parallel/test-cpu-prof-dir-relative.js b/test/sequential/test-cpu-prof-dir-relative.js similarity index 100% rename from test/parallel/test-cpu-prof-dir-relative.js rename to test/sequential/test-cpu-prof-dir-relative.js diff --git a/test/parallel/test-cpu-prof-dir-worker.js b/test/sequential/test-cpu-prof-dir-worker.js similarity index 100% rename from test/parallel/test-cpu-prof-dir-worker.js rename to test/sequential/test-cpu-prof-dir-worker.js diff --git a/test/parallel/test-cpu-prof-drained.js b/test/sequential/test-cpu-prof-drained.js similarity index 100% rename from test/parallel/test-cpu-prof-drained.js rename to test/sequential/test-cpu-prof-drained.js diff --git a/test/parallel/test-cpu-prof-exit.js b/test/sequential/test-cpu-prof-exit.js similarity index 100% rename from test/parallel/test-cpu-prof-exit.js rename to test/sequential/test-cpu-prof-exit.js diff --git a/test/parallel/test-cpu-prof-invalid-options.js b/test/sequential/test-cpu-prof-invalid-options.js similarity index 100% rename from test/parallel/test-cpu-prof-invalid-options.js rename to test/sequential/test-cpu-prof-invalid-options.js diff --git a/test/parallel/test-cpu-prof-kill.js b/test/sequential/test-cpu-prof-kill.js similarity index 100% rename from test/parallel/test-cpu-prof-kill.js rename to test/sequential/test-cpu-prof-kill.js diff --git a/test/parallel/test-cpu-prof-name.js b/test/sequential/test-cpu-prof-name.js similarity index 100% rename from test/parallel/test-cpu-prof-name.js rename to test/sequential/test-cpu-prof-name.js diff --git a/test/parallel/test-cpu-prof-worker-argv.js b/test/sequential/test-cpu-prof-worker-argv.js similarity index 100% rename from test/parallel/test-cpu-prof-worker-argv.js rename to test/sequential/test-cpu-prof-worker-argv.js