From 80076cb1c779bb9e40479ea8831815dea3d1eb25 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Thu, 6 Sep 2018 22:31:07 +0200 Subject: [PATCH] tracing: remove shutdown-on-signal MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This feature cannot be reasonably implemented this way without inherently being susceptible to race conditions that lead to hangs, crashes, etc. What’s more, implementing this for some signals only (and it can only be implemented for some signals at all) may lead to the impression that it is a guaranteed feature, when really consumers of the tracing output *need* to be able to handle abrupt ends meaningfully. Fixes: https://github.com/nodejs/node/issues/14802 Fixes: https://github.com/nodejs/node/issues/22528 PR-URL: https://github.com/nodejs/node/pull/22734 Reviewed-By: James M Snell Reviewed-By: Ali Ijaz Sheikh Reviewed-By: Ruben Bridgewater Reviewed-By: Matteo Collina --- src/node.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/node.cc b/src/node.cc index 6baf2222e82ec2..b4481f348b40ac 100644 --- a/src/node.cc +++ b/src/node.cc @@ -2053,7 +2053,6 @@ void SetupProcessObject(Environment* env, void SignalExit(int signo) { uv_tty_reset_mode(); - v8_platform.StopTracingAgent(); #ifdef __FreeBSD__ // FreeBSD has a nasty bug, see RegisterSignalHandler for details struct sigaction sa;