http: always emit close on req and res

PR-URL: #20611 Fixes: #20600 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
nodejs · May 14, 2018 · 8029a24 · 8029a24
1 parent 2db83fd
commit 8029a24
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -561,6 +561,8 @@ function resOnFinish(req, res, socket, state, server) {
     req._dump();
 
   res.detachSocket(socket);
+  req.emit('close');
+  res.emit('close');
 
   if (res._last) {
     if (typeof socket.destroySoon === 'function') {

diff --git a/test/parallel/test-http-req-res-close.js b/test/parallel/test-http-req-res-close.js
@@ -0,0 +1,16 @@
+'use strict';
+
+const common = require('../common');
+const http = require('http');
+
+const server = http.Server(common.mustCall((req, res) => {
+  res.end();
+  res.on('finish', common.mustCall());
+  res.on('close', common.mustCall());
+  req.on('close', common.mustCall());
+  res.socket.on('close', () => server.close());
+}));
+
+server.listen(0, common.mustCall(() => {
+  http.get({ port: server.address().port }, common.mustCall());
+}));