From 804eb3cd734176f123142f0db496279cb2f645fd Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Wed, 15 Nov 2017 22:02:08 +0100 Subject: [PATCH] src: remove process._debugPause() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This method is undocumented and depends on a V8 API that is slated for removal. The inspector and node-inspect don't use it and I could find no third-party code that depends on it. Remove it. PR-URL: https://github.com/nodejs/node/pull/17060 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Evan Lucas Reviewed-By: Michaƫl Zasso Reviewed-By: Refael Ackermann Reviewed-By: Timothy Gu --- src/node.cc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/node.cc b/src/node.cc index e1b80c239c659d..ad0f18c9a1cb88 100644 --- a/src/node.cc +++ b/src/node.cc @@ -67,7 +67,6 @@ #if NODE_USE_V8_PLATFORM #include "libplatform/libplatform.h" #endif // NODE_USE_V8_PLATFORM -#include "v8-debug.h" #include "v8-profiler.h" #include "zlib.h" @@ -2931,7 +2930,6 @@ static void DebugPortSetter(Local property, static void DebugProcess(const FunctionCallbackInfo& args); -static void DebugPause(const FunctionCallbackInfo& args); static void DebugEnd(const FunctionCallbackInfo& args); namespace { @@ -3363,7 +3361,6 @@ void SetupProcessObject(Environment* env, env->SetMethod(process, "_kill", Kill); env->SetMethod(process, "_debugProcess", DebugProcess); - env->SetMethod(process, "_debugPause", DebugPause); env->SetMethod(process, "_debugEnd", DebugEnd); env->SetMethod(process, "hrtime", Hrtime); @@ -4091,11 +4088,6 @@ static void DebugProcess(const FunctionCallbackInfo& args) { #endif // _WIN32 -static void DebugPause(const FunctionCallbackInfo& args) { - v8::Debug::DebugBreak(args.GetIsolate()); -} - - static void DebugEnd(const FunctionCallbackInfo& args) { #if HAVE_INSPECTOR Environment* env = Environment::GetCurrent(args);