From 80a114d1b715c8d70e480627bdeed0d3dab10986 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 24 Dec 2021 11:25:06 -0800 Subject: [PATCH] tools: be intentional about masking possible error in start-ci.sh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Revise start-ci.sh to conform with shellcheck 0.8.0 default checks. Refs: https://www.shellcheck.net/wiki/SC2312 PR-URL: https://github.com/nodejs/node/pull/41284 Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel --- tools/actions/start-ci.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/actions/start-ci.sh b/tools/actions/start-ci.sh index 174939aa4c413b..a34f2a9496fb26 100755 --- a/tools/actions/start-ci.sh +++ b/tools/actions/start-ci.sh @@ -17,7 +17,7 @@ for pr in "$@"; do # Do we need to reset? gh pr edit "$pr" --add-label "$REQUEST_CI_FAILED_LABEL" - jq -n --arg content "
Couldn't start CI
$(cat output)
" > output.json + jq -n --arg content "
Couldn't start CI
$(cat output || true)
" > output.json gh pr comment "$pr" --body-file output.json