From 8393ebc72daa122e07b66559ad944042d67bb886 Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Wed, 18 Jan 2023 17:37:37 -0300 Subject: [PATCH] build: build ICU with ICU_NO_USER_DATA_OVERRIDE Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/379 CVE-ID: CVE-2023-23920 PR-URL: https://github.com/nodejs-private/node-private/pull/374 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1625036 Reviewed-By: Richard Lau --- configure.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.py b/configure.py index 0a45c07f587ed8..62c01aaf6a386d 100755 --- a/configure.py +++ b/configure.py @@ -1722,6 +1722,9 @@ def icu_download(path): # always set icu_small, node.gyp depends on it being defined. o['variables']['icu_small'] = b(False) + # prevent data override + o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE'] + with_intl = options.with_intl with_icu_source = options.with_icu_source have_icu_path = bool(options.with_icu_path)