From 842028a160817fc7cd1d51c224621d82200815d7 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Thu, 14 Sep 2023 23:23:46 +0200 Subject: [PATCH] test: skip test-child-process-stdio-reuse-readable-stdio on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It is flaky due to the same cause of test-child-process-pipe-dataflow being flaky - cygwin quirks - so skip it on Windows too. Drive-by: remove the skip mark of test-child-process-pipe-dataflow in the status file and directly skip it in the test with a comment. PR-URL: https://github.com/nodejs/node/pull/49621 Backport-PR-URL: https://github.com/nodejs/node/pull/51132 Co-authored-by: Artur Yapparov Reviewed-By: Debadree Chatterjee Reviewed-By: Michaël Zasso Reviewed-By: LiviaMedeiros Reviewed-By: Luigi Pinca Reviewed-By: Moshe Atlow --- test/parallel/parallel.status | 3 --- test/parallel/test-child-process-pipe-dataflow.js | 6 ++++++ .../test-child-process-stdio-reuse-readable-stdio.js | 6 ++++++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index 58beb9d2c2e645..a500bcb603891e 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -11,9 +11,6 @@ prefix parallel test-crypto-keygen: PASS,FLAKY # https://github.com/nodejs/node/issues/41201 test-fs-rmdir-recursive: PASS, FLAKY -# https://github.com/nodejs/node/issues/48300 -test-child-process-pipe-dataflow: PASS, FLAKY -test-child-process-stdio-reuse-readable-stdio: PASS, FLAKY # https://github.com/nodejs/node/issues/49985 test-runner-watch-mode: PASS, FLAKY # https://github.com/nodejs/node/issues/50295 diff --git a/test/parallel/test-child-process-pipe-dataflow.js b/test/parallel/test-child-process-pipe-dataflow.js index e989ff135c8047..6d324ee783b54b 100644 --- a/test/parallel/test-child-process-pipe-dataflow.js +++ b/test/parallel/test-child-process-pipe-dataflow.js @@ -1,5 +1,11 @@ 'use strict'; const common = require('../common'); + +if (common.isWindows) { + // https://github.com/nodejs/node/issues/48300 + common.skip('Does not work with cygwin quirks on Windows'); +} + const assert = require('assert'); const path = require('path'); const fs = require('fs'); diff --git a/test/parallel/test-child-process-stdio-reuse-readable-stdio.js b/test/parallel/test-child-process-stdio-reuse-readable-stdio.js index 263270f8e8891f..19f746e25952df 100644 --- a/test/parallel/test-child-process-stdio-reuse-readable-stdio.js +++ b/test/parallel/test-child-process-stdio-reuse-readable-stdio.js @@ -1,5 +1,11 @@ 'use strict'; const common = require('../common'); + +if (common.isWindows) { + // https://github.com/nodejs/node/issues/48300 + common.skip('Does not work with cygwin quirks on Windows'); +} + const assert = require('assert'); const { spawn } = require('child_process');