Skip to content

Commit

Permalink
doc: add full list of subsystems
Browse files Browse the repository at this point in the history
PR-URL: #39971
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
  • Loading branch information
iam-frankqiu authored and BethGriggs committed Sep 21, 2021
1 parent f666f5a commit 8aad81d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions doc/guides/contributing/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,8 @@ If you want to know more about the code review and the landing process, see the
* `test`
* `tools`

You can find the full list of supported subsystems in the
[nodejs/core-validate-commit][] repository.
More than one subsystem may be valid for any particular issue or pull request.

[Building guide]: ../../../BUILDING.md
Expand All @@ -591,5 +593,6 @@ More than one subsystem may be valid for any particular issue or pull request.
[guide for writing tests in Node.js]: ../writing-tests.md
[hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment
[https://ci.nodejs.org/]: https://ci.nodejs.org/
[nodejs/core-validate-commit]: https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js
[pull request template]: https://raw.githubusercontent.com/nodejs/node/HEAD/.github/PULL_REQUEST_TEMPLATE.md
[running tests]: ../../../BUILDING.md#running-tests

0 comments on commit 8aad81d

Please sign in to comment.