From 8c33731ac63a3ec07a99ab3a533a71470fd8921f Mon Sep 17 00:00:00 2001 From: Jungku Lee Date: Sun, 20 Aug 2023 18:55:44 +0900 Subject: [PATCH] src: add a condition if the argument of `DomainToUnicode` is empty PR-URL: https://github.com/nodejs/node/pull/49097 Refs: https://github.com/nodejs/node/pull/46410 Reviewed-By: Yagiz Nizipli Reviewed-By: Deokjin Kim --- src/node_url.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/node_url.cc b/src/node_url.cc index 30a1a6ec9876ba..149a926841b635 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -95,6 +95,11 @@ void BindingData::DomainToUnicode(const FunctionCallbackInfo& args) { CHECK(args[0]->IsString()); std::string input = Utf8Value(env->isolate(), args[0]).ToString(); + if (input.empty()) { + return args.GetReturnValue().Set( + String::NewFromUtf8(env->isolate(), "").ToLocalChecked()); + } + // It is important to have an initial value that contains a special scheme. // Since it will change the implementation of `set_hostname` according to URL // spec.