From 8d3dcc5f438c2f98604e1de2cd3471a6df411454 Mon Sep 17 00:00:00 2001 From: kenzo-spaulding <51864231+kenzo-spaulding@users.noreply.github.com> Date: Fri, 24 Jan 2020 19:54:49 -0800 Subject: [PATCH] doc: update maintaining-V8.md Updated to conform to style guide. PR-URL: https://github.com/nodejs/node/pull/31503 Reviewed-By: Rich Trott Reviewed-By: Anna Henningsen --- doc/guides/maintaining-V8.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/maintaining-V8.md b/doc/guides/maintaining-V8.md index d33b745ac56b8e..f8a2c1aa305b0e 100644 --- a/doc/guides/maintaining-V8.md +++ b/doc/guides/maintaining-V8.md @@ -30,7 +30,7 @@ For example, at the time of this writing: All older branches are abandoned and are not maintained by the V8 team. -### V8 merge process overview +### V8 Merge Process Overview The process for backporting bug fixes to active branches is officially documented [on the V8 wiki][V8MergingPatching]. The summary of the process is: @@ -278,7 +278,7 @@ PR-URL: https://github.com/nodejs/node/pull/7833 normal and [V8 CI][] using the Node.js CI system. We only needed to backport to `v6.x` as the other LTS branches weren't affected by this bug. -### Backports Identified by the V8 team +### Backports Identified by the V8 Team For bugs found through the browser or other channels, the V8 team marks bugs that might be applicable to the abandoned branches in use by Node.js. This is @@ -313,7 +313,7 @@ Node.js keeps a vendored copy of V8 inside of the deps/ directory. In addition, Node.js may need to float patches that do not exist upstream. This means that some care may need to be taken to update the vendored copy of V8. -### Minor updates (patch level) +### Minor Updates (Patch Level) Because there may be floating patches on the version of V8 in Node.js, it is safest to apply the patch level updates as a patch. For example, imagine that @@ -378,7 +378,7 @@ git node v8 major --branch=5.1-lkgr This should be followed up with manual refloating of all relevant patches. -## Proposal: Using a fork repo to track upstream V8 +## Proposal: Using a Fork Repo to Track Upstream V8 The fact that Node.js keeps a vendored, potentially edited copy of V8 in deps/ makes the above processes a bit complicated. An alternative proposal would be to