From 9520762d33334c47745619c7b69280c2ff3cc8da Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Thu, 30 Mar 2017 11:11:55 -0400 Subject: [PATCH] test: performance, remove Popen(shell=True) on Win not needed according to official python docs - https://docs.python.org/2/library/subprocess.html#index-2 PR-URL: https://github.com/nodejs/node/pull/12138 Reviewed-By: Anna Henningsen Reviewed-By: Nikolai Vavilov Reviewed-By: James M Snell --- tools/test.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/test.py b/tools/test.py index d6715937b60da3..05a2dd92ae9f2f 100755 --- a/tools/test.py +++ b/tools/test.py @@ -616,7 +616,6 @@ def RunProcess(context, timeout, args, **rest): pty_out = rest.pop('pty_out') process = subprocess.Popen( - shell = utils.IsWindows(), args = popen_args, **rest )