src: handle empty value without newline at EOF

Author: ilyasShabiCS

src/node_dotenv.cc

@@ -104,7 +104,10 @@ std::string_view trim_spaces(std::string_view input) {
 }
 
 void Dotenv::ParseContent(const std::string_view input) {
-  std::string_view content = input;
+  std::string lines =
+      std::regex_replace(std::string(input), std::regex("\r\n?"), "\n");
+
+  std::string_view content = lines;
   content = trim_spaces(content);
 
   std::string_view key;
@@ -142,6 +145,9 @@ void Dotenv::ParseContent(const std::string_view input) {
 
     // SAFETY: Content is guaranteed to have at least one character
     if (content.empty()) {
+      // In case the last line is a single key without value
+      // Example: KEY= (without a newline at the EOF)
+      store_.insert_or_assign(std::string(key), "");
       break;
     }
 

test/fixtures/dotenv/eof-without-value.env

@@ -0,0 +1,2 @@
+BASIC=value
+EMPTY=

test/parallel/test-dotenv-edge-cases.js

@@ -81,4 +81,21 @@ describe('.env supports edge cases', () => {
     assert.strictEqual(child.stderr, '');
     assert.strictEqual(child.code, 0);
   });
+
+  it('should handle empty value without a newline at the EOF', async () => {
+    // Ref: https://github.com/nodejs/node/issues/52466
+    const code = `
+      process.loadEnvFile('./eof-without-value.env');
+      require('assert').strictEqual(process.env.BASIC, 'value');
+      require('assert').strictEqual(process.env.EMPTY, '');
+    `.trim();
+    const child = await common.spawnPromisified(
+      process.execPath,
+      [ '--eval', code ],
+      { cwd: fixtures.path('dotenv') },
+    );
+    assert.strictEqual(child.stdout, '');
+    assert.strictEqual(child.stderr, '');
+    assert.strictEqual(child.code, 0);
+  });
 });