From 9881da1585574fe2e0b655d3cf9f9c5299f25c7a Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 14 Apr 2017 21:59:21 -0700 Subject: [PATCH] doc: run tests before landing changes The Collaborator Guide suggests running tests after pushing changes to the main repository. Tests should be run before then so move the instructions earlier. Instructions are also simplified and re-written to not exclude Windows. PR-URL: https://github.com/nodejs/node/pull/12416 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Daniel Bevenius Reviewed-By: Alexey Orlenko Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Gibson Fahnestock --- COLLABORATOR_GUIDE.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index e955473a685a39..548f22235472da 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -445,6 +445,10 @@ commit logs, ensure that they are properly formatted, and add * The commit message text must conform to the [commit message guidelines](./CONTRIBUTING.md#step-3-commit). +Run tests (`make -j4 test` or `vcbuild test`). Even though there was a +successful continuous integration run, other changes may have landed on master +since then, so running the tests one last time locally is a good practice. + Time to push it: ```text @@ -463,11 +467,6 @@ your pull request shows the purple merged status then you should still add the "Landed in .." comment if you added multiple commits. -* `./configure && make -j8 test` - * `-j8` builds node in parallel with 8 threads. Adjust to the number - of cores or processor-level threads your processor has (or slightly - more) for best results. - ### I Just Made a Mistake * Ping a CTC member.