Skip to content

Commit

Permalink
Revert "src: fix stuck debugger process"
Browse files Browse the repository at this point in the history
This reverts commit ff877e9.

Reverted for breaking `node --debug-brk -e 0`.  It should immediately
quit but instead it hangs now.

PR-URL: #3585
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
bnoordhuis committed Oct 29, 2015
1 parent 57bce60 commit 9b02442
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3747,6 +3747,7 @@ void Init(int* argc,
uv_async_init(uv_default_loop(),
&dispatch_debug_messages_async,
DispatchDebugMessagesAsyncCallback);
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));

#if defined(NODE_V8_OPTIONS)
// Should come before the call to V8::SetFlagsFromCommandLine()
Expand Down Expand Up @@ -4054,11 +4055,8 @@ static void StartNodeInstance(void* arg) {
env->set_trace_sync_io(trace_sync_io);

// Enable debugger
if (instance_data->use_debug_agent()) {
if (instance_data->use_debug_agent())
EnableDebug(env);
} else {
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));
}

{
SealHandleScope seal(isolate);
Expand Down

0 comments on commit 9b02442

Please sign in to comment.