From a03d3afa69451f32b74322858ece842132f67904 Mon Sep 17 00:00:00 2001 From: Rongjian Zhang Date: Sat, 8 May 2021 17:09:18 +0800 Subject: [PATCH] http: refactor to remove redundant argument of _deferToConnect PR-URL: https://github.com/nodejs/node/pull/38598 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel --- lib/_http_client.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/_http_client.js b/lib/_http_client.js index 4184191c0fbabc..f3b88b62730175 100644 --- a/lib/_http_client.js +++ b/lib/_http_client.js @@ -818,7 +818,7 @@ function onSocketNT(req, socket, err) { } ClientRequest.prototype._deferToConnect = _deferToConnect; -function _deferToConnect(method, arguments_, cb) { +function _deferToConnect(method, arguments_) { // This function is for calls that need to happen once the socket is // assigned to this request and writable. It's an important promisy // thing for all the socket calls that happen either now @@ -828,9 +828,6 @@ function _deferToConnect(method, arguments_, cb) { const callSocketMethod = () => { if (method) ReflectApply(this.socket[method], this.socket, arguments_); - - if (typeof cb === 'function') - cb(); }; const onSocket = () => {