Skip to content

Commit

Permalink
configure: v8_use_snapshot should be true
Browse files Browse the repository at this point in the history
`v8_use_snapshot` should be either `true` or `false`, not 1 or 0.

PR-URL: #3962
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
  • Loading branch information
indutny authored and Myles Borins committed Dec 15, 2015
1 parent e73d697 commit a29d6d3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ def configure_v8(o):
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
o['variables']['v8_optimized_debug'] = 0 # Compile with -O0 in debug builds.
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
o['variables']['v8_use_snapshot'] = 0 if options.without_snapshot else 1
o['variables']['v8_use_snapshot'] = 'false' if options.without_snapshot else 'true'

def configure_openssl(o):
o['variables']['node_use_openssl'] = b(not options.without_ssl)
Expand Down

0 comments on commit a29d6d3

Please sign in to comment.