Skip to content

Commit

Permalink
repl: remove deprecated repl.memory function
Browse files Browse the repository at this point in the history
This removes the memory function. It is deprecated for a long time
while not being really helpful being exposed. Thus, it is removed
to improve maintainability of the REPL module.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
BridgeAR committed May 23, 2020
1 parent f217b2d commit a416692
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 21 deletions.
5 changes: 4 additions & 1 deletion doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -1696,12 +1696,15 @@ file descriptors.
### DEP0082: `REPLServer.prototype.memory()`
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/33286
description: End-of-Life.
- version: v9.0.0
pr-url: https://github.com/nodejs/node/pull/16242
description: Runtime deprecation.
-->
Type: Runtime
Type: End-of-Life
`REPLServer.prototype.memory()` is only necessary for the internal mechanics of
the `REPLServer` itself. Do not use this function.
Expand Down
5 changes: 0 additions & 5 deletions lib/repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -1352,11 +1352,6 @@ REPLServer.prototype.defineCommand = function(keyword, cmd) {
this.commands[keyword] = cmd;
};

REPLServer.prototype.memory = deprecate(
_memory,
'REPLServer.memory() is deprecated',
'DEP0082');

// TODO(BridgeAR): This should be replaced with acorn to build an AST. The
// language became more complex and using a simple approach like this is not
// sufficient anymore.
Expand Down
15 changes: 0 additions & 15 deletions test/parallel/test-repl-memory-deprecation.js

This file was deleted.

0 comments on commit a416692

Please sign in to comment.