From a545cfe2936d4e09f4f3d69f7b67f8871cf249c6 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 24 Mar 2019 15:56:53 -0700 Subject: [PATCH] doc: edit "How Can I Help?" in Collaborator Guide Edit the "How Can I Help?" section of the Collaborator Guide to keep sentences simple, short, and direct. PR-URL: https://github.com/nodejs/node/pull/26895 Reviewed-By: James M Snell Reviewed-By: Daniel Bevenius Reviewed-By: Yongsheng Zhang Reviewed-By: Ruben Bridgewater --- COLLABORATOR_GUIDE.md | 48 +++++++++++++++++++------------------------ 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 6be5ceda12f3fa..09d11eb9691073 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -659,33 +659,27 @@ branches. #### How can I help? -When you send your pull request, please include information about whether your -change is breaking. If you think your patch can be backported, please include -that information in the PR thread or your PR description. For more information -on backporting, please see the [backporting guide][]. - -Several LTS related issue and PR labels have been provided: - -* `lts-watch-v10.x` - tells the LTS WG that the issue/PR needs to be - considered for landing in the `v10.x-staging` branch. -* `lts-watch-v8.x` - tells the LTS WG that the issue/PR needs to be - considered for landing in the `v8.x-staging` branch. -* `lts-watch-v6.x` - tells the LTS WG that the issue/PR needs to be - considered for landing in the `v6.x-staging` branch. -* `land-on-v10.x` - tells the release team that the commit should be landed - in a future v10.x release. -* `land-on-v8.x` - tells the release team that the commit should be landed - in a future v8.x release. -* `land-on-v6.x` - tells the release team that the commit should be landed - in a future v6.x release. - -Any Collaborator can attach these labels to any PR/issue. As commits are -landed into the staging branches, the `lts-watch-` label will be removed. -Likewise, as commits are landed in a LTS release, the `land-on-` label will -be removed. - -Collaborators are encouraged to help the LTS WG by attaching the appropriate -`lts-watch-` label to any PR that may impact an LTS release. +When you send your pull request, please state if your change is breaking. Also +state if you think your patch is a good candidate for backporting. For more +information on backporting, please see the [backporting guide][]. + +There are several LTS-related labels: + +* `lts-watch-` labels are for pull requests to consider for landing in staging + branches. For example, `lts-watch-v10.x` would be for a change + to consider for the `v10.x-staging` branch. + +* `land-on-` are for pull requests that should land in a future v*.x + release. For example, `land-on-v10.x` would be for a change to land in Node.js + 10.x. + +Any Collaborator can attach these labels to any pull request/issue. As commits +land on the staging branches, the backporter removes the `lts-watch-` label. +Likewise, as commits land in an LTS release, the releaser removes the `land-on-` +label. + +Attach the appropriate `lts-watch-` label to any PR that may impact an LTS +release. #### How is an LTS release cut?