Skip to content

Commit

Permalink
fs: only use Buffer.concat in promises.readFile when necessary
Browse files Browse the repository at this point in the history
PR-URL: #37127
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
addaleax authored and targos committed Feb 2, 2021
1 parent 8cecce3 commit ad12fef
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/internal/fs/promises.js
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ async function readFileHandle(filehandle, options) {
ArrayPrototypePush(chunks, buffer.slice(0, bytesRead));
} while (!endOfFile);

const result = Buffer.concat(chunks);
const result = chunks.length === 1 ? chunks[0] : Buffer.concat(chunks);

return options.encoding ? result.toString(options.encoding) : result;
}
Expand Down

0 comments on commit ad12fef

Please sign in to comment.