sync

nodejs · Mar 21, 2023 · af689a4 · af689a4
1 parent 1640aeb
commit af689a4
Show file tree

Hide file tree

Showing 1,038 changed files with 4,335 additions and 6,113 deletions.
diff --git a/.github/ISSUE_TEMPLATE/1-bug-report.yml b/.github/ISSUE_TEMPLATE/1-bug-report.yml
@@ -33,7 +33,7 @@ body:
       label: How often does it reproduce? Is there a required condition?
   - type: textarea
     attributes:
-      label: What is the expected behavior? Why is that the expected behavior?
+      label: What is the expected behavior?
       description: If possible please provide textual output instead of screenshots.
   - type: textarea
     attributes:

diff --git a/.github/workflows/daily-wpt-fyi.yml b/.github/workflows/daily-wpt-fyi.yml
@@ -81,74 +81,34 @@ jobs:
           clean: false
           ref: ${{ env.WPT_REVISION }}
 
-      # Node.js WPT Runner
       - name: Run WPT and generate report
+        run: make test-wpt-report || true
+      - name: Clone report for upload
         run: |
-          make test-wpt-report || true
           if [ -e out/wpt/wptreport.json ]; then
-            echo "WPT_REPORT=$(pwd)/out/wpt/wptreport.json" >> $GITHUB_ENV
+            cd out/wpt
+            cp wptreport.json wptreport-${{ steps.setup-node.outputs.node-version }}.json
           fi
-
-      # undici WPT Runner
-      - name: Set env.UNDICI_VERSION
-        if: ${{ env.WPT_REPORT != '' }}
-        run: echo "UNDICI_VERSION=v$(jq -r '.version' < deps/undici/src/package.json)" >> $GITHUB_ENV
-      - name: Remove deps/undici
-        if: ${{ env.WPT_REPORT != '' }}
-        run: rm -rf deps/undici
-      - name: Checkout undici
-        if: ${{ env.WPT_REPORT != '' }}
-        uses: actions/checkout@v3
-        with:
-          repository: nodejs/undici
-          persist-credentials: false
-          path: deps/undici
-          clean: false
-          ref: ${{ env.UNDICI_VERSION }}
-      - name: Add undici WPTs to the report
-        if: ${{ env.WPT_REPORT != '' }}
-        run: |
-          rm -rf test/wpt/tests
-          mv ../../test/fixtures/wpt/ test/wpt/tests/
-          npm install
-          npm run test:wpt || true
-        working-directory: deps/undici
-
-      # Upload artifacts
-      - name: Clone report for upload
-        if: ${{ env.WPT_REPORT != '' }}
-        working-directory: out/wpt
-        run: cp wptreport.json wptreport-${{ steps.setup-node.outputs.node-version }}.json
       - name: Upload GitHub Actions artifact
-        if: ${{ env.WPT_REPORT != '' }}
         uses: actions/upload-artifact@v3
         with:
           path: out/wpt/wptreport-*.json
           name: WPT Reports
-          if-no-files-found: error
+          if-no-files-found: warn
       - name: Upload WPT Report to wpt.fyi API
-        if: ${{ env.WPT_REPORT != '' }}
         env:
           WPT_FYI_USERNAME: ${{ vars.WPT_FYI_USERNAME }}
           WPT_FYI_PASSWORD: ${{ secrets.WPT_FYI_PASSWORD }}
-        working-directory: out/wpt
         run: |
-          gzip wptreport.json
-          echo "## Node.js ${{ steps.setup-node.outputs.node-version }}" >> $GITHUB_STEP_SUMMARY
-          for WPT_FYI_ENDPOINT in "https://wpt.fyi/api/results/upload" "https://staging.wpt.fyi/api/results/upload"
-          do
-            response=$(curl -sS \
-              -u "$WPT_FYI_USERNAME:$WPT_FYI_PASSWORD" \
-              -F "result_file=@wptreport.json.gz" \
-              -F "labels=master" \
-              $WPT_FYI_ENDPOINT)
-
-            if [[ $response =~ Task\ ([0-9]+)\ added\ to\ queue ]]; then
-              run_id=${BASH_REMATCH[1]}
-              origin=${WPT_FYI_ENDPOINT%/api/results/upload}
-
-              echo "" >> $GITHUB_STEP_SUMMARY
-              echo "Run ID [$run_id]($origin/api/runs/$run_id) added to the processor queue at $origin" >> $GITHUB_STEP_SUMMARY
-              echo "- [View on the ${origin:8} dashboard]($origin/results?run_id=$run_id)" >> $GITHUB_STEP_SUMMARY
-            fi
-          done
+          if [ -e out/wpt/wptreport.json ]; then
+            cd out/wpt
+            gzip wptreport.json
+            for WPT_FYI_ENDPOINT in "https://wpt.fyi/api/results/upload" "https://staging.wpt.fyi/api/results/upload"
+            do
+              curl \
+                -u "$WPT_FYI_USERNAME:$WPT_FYI_PASSWORD" \
+                -F "result_file=@wptreport.json.gz" \
+                -F "labels=master" \
+                $WPT_FYI_ENDPOINT
+            done
+          fi
diff --git a/.github/workflows/find-inactive-tsc.yml b/.github/workflows/find-inactive-tsc.yml
@@ -1,4 +1,4 @@
-name: Find inactive TSC voting members
+name: Find inactive TSC members
 
 on:
   schedule:
@@ -38,7 +38,7 @@ jobs:
         with:
           node-version: ${{ env.NODE_VERSION }}
 
-      - name: Find inactive TSC voting members
+      - name: Find inactive TSC members
         run: tools/find-inactive-tsc.mjs >> $GITHUB_ENV
 
       - name: Open pull request
@@ -56,6 +56,6 @@ jobs:
             @nodejs/tsc ${{ env.INACTIVE_TSC_HANDLES }}
 
             ${{ env.DETAILS_FOR_COMMIT_BODY }}
-          commit-message: 'meta: move TSC voting member(s) to regular member(s)'
+          commit-message: 'meta: move one or more TSC members to emeritus'
           labels: meta
-          title: 'meta: move TSC voting member(s) to regular member(s)'
+          title: 'meta: move one or more TSC members to emeritus'
diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml
@@ -134,10 +134,12 @@ jobs:
             subsystem: deps
             label: dependencies
             run: |
-              ./tools/dep_updaters/update-ada.sh > temp-output
-              cat temp-output
-              tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
-              rm temp-output
+              NEW_VERSION=$(gh api repos/ada-url/ada/releases/latest -q '.tag_name|ltrimstr("v")')
+              CURRENT_VERSION=$(grep "#define ADA_VERSION" ./deps/ada/ada.h | sed -n "s/^.*VERSION \(.*\)/\1/p")
+              if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
+                echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
+                ./tools/dep_updaters/update-ada.sh "$NEW_VERSION"
+              fi
           - id: nghttp2
             subsystem: deps
             label: dependencies

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -35,9 +35,7 @@ release.
 </tr>
 <tr>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V19.md#19.8.1">19.8.1</a></b><br/>
-<a href="doc/changelogs/CHANGELOG_V19.md#19.8.0">19.8.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V19.md#19.7.0">19.7.0</a><br/>
+<b><a href="doc/changelogs/CHANGELOG_V19.md#19.7.0">19.7.0</a></b><br/>
 <a href="doc/changelogs/CHANGELOG_V19.md#19.6.1">19.6.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V19.md#19.6.0">19.6.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V19.md#19.5.0">19.5.0</a><br/>

diff --git a/GOVERNANCE.md b/GOVERNANCE.md
@@ -118,8 +118,8 @@ the issue tracker is:
 
 * A TSC member opens an issue explaining the proposal/issue and @-mentions
   @nodejs/tsc.
-* The proposal passes if, after 72 hours, there are two or more TSC voting
-  member approvals and no TSC voting member opposition.
+* The proposal passes if, after 72 hours, there are two or more TSC approvals
+  and no TSC opposition.
 * If there is an extended impasse, a TSC member may make a motion for a vote.
 
 ## Collaborator nominations

diff --git a/README.md b/README.md
@@ -158,8 +158,6 @@ For information about the governance of the Node.js project, see
 
 ### TSC (Technical Steering Committee)
 
-#### TSC voting members
-
 <!--lint disable prohibited-strings-->
 
 * [aduh95](https://github.com/aduh95) -
@@ -176,6 +174,8 @@ For information about the governance of the Node.js project, see
   **Colin Ihrig** <<cjihrig@gmail.com>> (he/him)
 * [danielleadams](https://github.com/danielleadams) -
   **Danielle Adams** <<adamzdanielle@gmail.com>> (she/her)
+* [fhinkel](https://github.com/fhinkel) -
+  **Franziska Hinkelmann** <<franziska.hinkelmann@gmail.com>> (she/her)
 * [GeoffreyBooth](https://github.com/geoffreybooth) -
   **Geoffrey Booth** <<webadmin@geoffreybooth.com>> (he/him)
 * [gireeshpunathil](https://github.com/gireeshpunathil) -
@@ -205,41 +205,28 @@ For information about the governance of the Node.js project, see
 * [Trott](https://github.com/Trott) -
   **Rich Trott** <<rtrott@gmail.com>> (he/him)
 
-#### TSC regular members
+<details>
+
+<summary>Emeriti</summary>
+
+### TSC emeriti
 
 * [addaleax](https://github.com/addaleax) -
   **Anna Henningsen** <<anna@addaleax.net>> (she/her)
 * [bnoordhuis](https://github.com/bnoordhuis) -
   **Ben Noordhuis** <<info@bnoordhuis.nl>>
+* [chrisdickinson](https://github.com/chrisdickinson) -
+  **Chris Dickinson** <<christopher.s.dickinson@gmail.com>>
 * [codebytere](https://github.com/codebytere) -
   **Shelley Vohr** <<shelley.vohr@gmail.com>> (she/her)
 * [danbev](https://github.com/danbev) -
   **Daniel Bevenius** <<daniel.bevenius@gmail.com>> (he/him)
-* [fhinkel](https://github.com/fhinkel) -
-  **Franziska Hinkelmann** <<franziska.hinkelmann@gmail.com>> (she/her)
-* [gabrielschulhof](https://github.com/gabrielschulhof) -
-  **Gabriel Schulhof** <<gabrielschulhof@gmail.com>>
-* [mscdex](https://github.com/mscdex) -
-  **Brian White** <<mscdex@mscdex.net>>
-* [MylesBorins](https://github.com/MylesBorins) -
-  **Myles Borins** <<myles.borins@gmail.com>> (he/him)
-* [rvagg](https://github.com/rvagg) -
-  **Rod Vagg** <<r@va.gg>>
-* [TimothyGu](https://github.com/TimothyGu) -
-  **Tiancheng "Timothy" Gu** <<timothygu99@gmail.com>> (he/him)
-
-<details>
-
-<summary>TSC emeriti members</summary>
-
-#### TSC emeriti members
-
-* [chrisdickinson](https://github.com/chrisdickinson) -
-  **Chris Dickinson** <<christopher.s.dickinson@gmail.com>>
 * [evanlucas](https://github.com/evanlucas) -
   **Evan Lucas** <<evanlucas@me.com>> (he/him)
 * [Fishrock123](https://github.com/Fishrock123) -
   **Jeremiah Senkpiel** <<fishrock123@rocketmail.com>> (he/they)
+* [gabrielschulhof](https://github.com/gabrielschulhof) -
+  **Gabriel Schulhof** <<gabrielschulhof@gmail.com>>
 * [gibfahn](https://github.com/gibfahn) -
   **Gibson Fahnestock** <<gibfahn@gmail.com>> (he/him)
 * [indutny](https://github.com/indutny) -
@@ -250,6 +237,10 @@ For information about the governance of the Node.js project, see
   **Josh Gavant** <<josh.gavant@outlook.com>>
 * [mmarchini](https://github.com/mmarchini) -
   **Mary Marchini** <<oss@mmarchini.me>> (she/her)
+* [mscdex](https://github.com/mscdex) -
+  **Brian White** <<mscdex@mscdex.net>>
+* [MylesBorins](https://github.com/MylesBorins) -
+  **Myles Borins** <<myles.borins@gmail.com>> (he/him)
 * [nebrius](https://github.com/nebrius) -
   **Bryan Hughes** <<bryan@nebri.us>>
 * [ofrobots](https://github.com/ofrobots) -
@@ -258,12 +249,16 @@ For information about the governance of the Node.js project, see
   **Alexis Campailla** <<orangemocha@nodejs.org>>
 * [piscisaureus](https://github.com/piscisaureus) -
   **Bert Belder** <<bertbelder@gmail.com>>
+* [rvagg](https://github.com/rvagg) -
+  **Rod Vagg** <<r@va.gg>>
 * [sam-github](https://github.com/sam-github) -
   **Sam Roberts** <<vieuxtech@gmail.com>>
 * [shigeki](https://github.com/shigeki) -
   **Shigeki Ohtsu** <<ohtsu@ohtsu.org>> (he/him)
 * [thefourtheye](https://github.com/thefourtheye) -
   **Sakthipriyan Vairamani** <<thechargingvolcano@gmail.com>> (he/him)
+* [TimothyGu](https://github.com/TimothyGu) -
+  **Tiancheng "Timothy" Gu** <<timothygu99@gmail.com>> (he/him)
 * [trevnorris](https://github.com/trevnorris) -
   **Trevor Norris** <<trev.norris@gmail.com>>
 

diff --git a/benchmark/url/url-searchparams-creation.js b/benchmark/url/url-searchparams-creation.js