Skip to content

Commit

Permalink
win,node-gyp: optionally allow node.exe/iojs.exe to be renamed
Browse files Browse the repository at this point in the history
On Windows, when node or io.js attempts to dynamically load a compiled
addon, the compiled addon tries to load node.exe or iojs.exe again -
depending on which import library the module used when it was linked.
This causes many compiled addons to break when node.exe or iojs.exe are
renamed, because when the binary has been renamed the addon DLL can't
find the (right) .exe file to load its imports from.

This patch gives compiled addon developers an option to overcome this
restriction by compiling a delay-load hook into their binary. The
delay-load hook ensures that whenever a module tries to load imports
from node.exe/iojs.exe, it'll just look at the process image, thereby
making the addon work regardless of what name the node/iojs binary has.

To enable this feature, the addon developer must set the
'win_delay_load_hook' option to 'true' in their binding.gyp file, like
this:

```
{
  'targets': [
    {
      'target_name': 'ernie',
      'win_delay_load_hook': 'true',
      ...
```

Bug: #751
Bug: #965
Upstream PR: nodejs/node-gyp#599

PR-URL: #1251
Reviewed-By: Rod Vagg <rod@vagg.org>

PR-URL: #1266
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
piscisaureus committed Mar 30, 2015
1 parent 2752da4 commit ba93c58
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 0 deletions.
25 changes: 25 additions & 0 deletions deps/npm/node_modules/node-gyp/addon.gypi

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions deps/npm/node_modules/node-gyp/src/win_delay_load_hook.c

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ba93c58

Please sign in to comment.