From bd9cb409770baed2c33fb2cf8d9497c7fe6a8e93 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 26 Oct 2016 16:50:11 -0700 Subject: [PATCH] test: run all of test-timers-blocking-callback The test has two test cases, but only the first was being run due to a small bug. This change fixes the bug. PR-URL: https://github.com/nodejs/node/pull/9305 Reviewed-By: Julien Gilli Reviewed-By: Colin Ihrig --- test/parallel/test-timers-blocking-callback.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-timers-blocking-callback.js b/test/parallel/test-timers-blocking-callback.js index aff28d1df7ef25..e4e85cddc6302d 100644 --- a/test/parallel/test-timers-blocking-callback.js +++ b/test/parallel/test-timers-blocking-callback.js @@ -56,24 +56,24 @@ function blockingCallback(callback) { common.busyLoop(TIMEOUT); timeCallbackScheduled = Timer.now(); - setTimeout(blockingCallback, TIMEOUT); + setTimeout(blockingCallback.bind(null, callback), TIMEOUT); } } -function testAddingTimerToEmptyTimersList(callback) { +const testAddingTimerToEmptyTimersList = common.mustCall(function(callback) { initTest(); // Call setTimeout just once to make sure the timers list is // empty when blockingCallback is called. setTimeout(blockingCallback.bind(null, callback), TIMEOUT); -} +}); -function testAddingTimerToNonEmptyTimersList() { +const testAddingTimerToNonEmptyTimersList = common.mustCall(function() { initTest(); // Call setTimeout twice with the same timeout to make // sure the timers list is not empty when blockingCallback is called. setTimeout(blockingCallback, TIMEOUT); setTimeout(blockingCallback, TIMEOUT); -} +}); // Run the test for the empty timers list case, and then for the non-empty // timers list one