From be6203715a43b8e239a68c474d964a5e0fd4b6a0 Mon Sep 17 00:00:00 2001 From: Sam Roberts Date: Thu, 22 Dec 2016 10:31:36 -0800 Subject: [PATCH] src: describe what NODE_MODULE_VERSION is for Current comment described what to do with it when the ABI changes, but implied that Node.js would load modules with newer ABI numbers, which it will not. PR-URL: https://github.com/nodejs/node/pull/10414 Reviewed-By: Anna Henningsen Reviewed-By: Gibson Fahnestock Reviewed-By: Italo A. Casas Reviewed-By: James M Snell Reviewed-By: Santiago Gimeno Reviewed-By: Sakthipriyan Vairamani --- src/node_version.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/node_version.h b/src/node_version.h index 1d0eb050d64a17..946b073bc0804c 100644 --- a/src/node_version.h +++ b/src/node_version.h @@ -47,6 +47,9 @@ (minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION)) /** + * Node.js will refuse to load modules that weren't compiled against its own + * module ABI number, exposed as the process.versions.modules property. + * * When this version number is changed, node.js will refuse * to load older modules. This should be done whenever * an API is broken in the C++ side, including in v8 or